Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let pari's spkg-configure accept pari 2.13 #30906

Closed
dimpase opened this issue Nov 13, 2020 · 18 comments
Closed

let pari's spkg-configure accept pari 2.13 #30906

dimpase opened this issue Nov 13, 2020 · 18 comments

Comments

@dimpase
Copy link
Member

dimpase commented Nov 13, 2020

some formats have changed, so tests fail, see
#30801 comment:6

Depends on #30801

CC: @tobihan @thierry-FreeBSD @orlitzky @mkoeppe @antonio-rojas @videlec @dkwo

Component: build: configure

Branch/Commit: u/dimpase/build/pari213fix @ ad702bf

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/30906

@dimpase dimpase added this to the sage-9.3 milestone Nov 13, 2020
@dimpase
Copy link
Member Author

dimpase commented Nov 13, 2020

New commits:

ad702bfdo the bnfisunit check in Pari, not rely on output

@dimpase
Copy link
Member Author

dimpase commented Nov 13, 2020

Commit: ad702bf

@dimpase
Copy link
Member Author

dimpase commented Nov 13, 2020

Author: Dima Pasechnik

@dimpase
Copy link
Member Author

dimpase commented Nov 13, 2020

Branch: u/dimpase/build/pari213fix

@dimpase
Copy link
Member Author

dimpase commented Dec 3, 2020

comment:4

ping

@dimpase
Copy link
Member Author

dimpase commented Dec 3, 2020

comment:5

on Gentoo this blocks using system pari

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 3, 2020

comment:7

The pari upgrade to the same version in #30801 seems to require nontrivial changes to Sage code and tests and also involves an upgrade of cypari2. How come we should just be able to be accepting system pari 2.13?

@dimpase
Copy link
Member Author

dimpase commented Dec 31, 2020

comment:9

made it conditional on pari update to 2.13

@dimpase
Copy link
Member Author

dimpase commented Dec 31, 2020

Dependencies: #30801

@dkwo
Copy link
Contributor

dkwo commented Feb 9, 2021

comment:10

On my Void linux machine, what works is

$ echo "bnf = bnfinit(y^4-y-1); bnfisunit(bnf,-y^3+2*y^2-1)==[0,2,0]~" | gp -qf
1

with only one square parenthesis, not two.

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 9, 2021

comment:12

the two brackets are m4 syntax

@dkwo
Copy link
Contributor

dkwo commented Feb 9, 2021

comment:13

I see, thanks.
However, even if I edit the file as per the commit, the bnfisunit test still fails for me with pari 2.13.0 using ./config, even though from a shell I get as above.

What am I missing?

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 9, 2021

comment:14

Did you run ./bootstrap?

@dkwo
Copy link
Contributor

dkwo commented Feb 9, 2021

comment:15

That fixes it, thanks.

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 17, 2021

comment:17

Looks like #30801 is taking care of this

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 17, 2021

Changed author from Dima Pasechnik to none

@mkoeppe mkoeppe removed this from the sage-9.3 milestone Mar 17, 2021
@dimpase
Copy link
Member Author

dimpase commented Mar 18, 2021

comment:18

yep. looks like the fix here was copied there.

@dimpase
Copy link
Member Author

dimpase commented Mar 18, 2021

Reviewer: Dima Pasechnik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants