-
-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
some flake8 details in backend normaliz #30878
Comments
Branch: u/chapoton/30878 |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Commit: |
comment:4
This seems inconsistent to me: - h_vertices = [ list(v) + [1] for v in vertices ]
+ h_vertices = [list(v) + [1] for v in vertices] - dieq = [ ZZ(d*ieq_i) for ieq_i in ieq ]
+ dieq = [ ZZ(d * ieq_i) for ieq_i in ieq ] |
comment:5
well, I was tempted to remove (as suggested by flake8) all superfluous whitespace before or after brackets. But then I decide to try to keep the diff small, so I did that only once. |
comment:6
I think |
Reviewer: Jonathan Kliem |
Changed branch from u/chapoton/30878 to |
and also fix two lgtm warnings
nothing serious, mostly cosmetic changes
CC: @jplab @LaisRast @kliem @sophiasage
Component: geometry
Author: Frédéric Chapoton
Branch/Commit:
310903a
Reviewer: Jonathan Kliem
Issue created by migration from https://trac.sagemath.org/ticket/30878
The text was updated successfully, but these errors were encountered: