Define a new data structure for a combinatorial face

[kliem]

We define a new data structure for a combinatorial face that accesses the underlying bitset functions.

See #30549 for doctesting.

Depends on #30601

CC: @tscrim

Component: geometry

Keywords: combinatorial face, bitset

Author: Jonathan Kliem

Branch/Commit: bb33866

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/30598

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

c9ba96b

put imports in order

[sagetrac-git]

Changed commit from e421d30 to c9ba96b

[sagetrac-git]

Changed commit from c9ba96b to a369269

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

d5e06fd	move bitset.pxi to proper header file
a31fb27	new data structure for a combinatorial face of a polyhedron
a369269	put imports in order

[kliem]

Changed dependencies from #30597 to #30601

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

bb33866

import instead of include

[sagetrac-git]

Changed commit from a369269 to bb33866

[videlec]

comment:7

This pure C code is not used anywhere... it is a strange looking ticket.

[kliem]

comment:8

I know.

#30549 is a patchbomb already and I'm trying to make it as easy as possible.
Everything is used in there.
The idea was to outsource stuff that can be easily reviewed.

One could of course add a pyx file solely that tries to test things.

[tscrim]

comment:9

LGTM.

[tscrim]

Reviewer: Travis Scrimshaw

[kliem]

comment:10

Thank you.

Btw, at some point soon, I will have to move this file again, as there is at least two other places in sage that can use this algorithm. This might involve some renaming.

Maybe it might be a good idea to do this now and reopen this ticket. What do you think?

[tscrim]

comment:11

I think it is fine on a separate ticket, perhaps just when you do that move.

[vbraun]

Changed branch from u/gh-kliem/data_structure_for_combinatorial_face to bb33866