Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More direct check for simple/simplicial polytopes #30428

Closed
kliem opened this issue Aug 24, 2020 · 7 comments
Closed

More direct check for simple/simplicial polytopes #30428

kliem opened this issue Aug 24, 2020 · 7 comments
Labels
c: geometry p: minor / 4 t: enhancement
Milestone
sage-9.2

Comments

@kliem
Copy link
Contributor

kliem commented Aug 24, 2020

We simplify checking for whether a polyhedron is simple or simplicial by just counting the number of set bits in the vertices/facets.

CC: @jplab @LaisRast @tscrim

Component: geometry

Keywords: simple, simplicial, combinatorial polyheddron

Author: Jonathan Kliem

Branch/Commit: 39f3a38

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/30428
@kliem kliem added this to the sage-9.2 milestone Aug 24, 2020
@kliem
Copy link
Contributor Author

kliem commented Aug 24, 2020

Branch: public/30428

@kliem
Copy link
Contributor Author

kliem commented Aug 24, 2020

Commit: 39f3a38

@kliem
Copy link
Contributor Author

kliem commented Aug 24, 2020

New commits:

39f3a38directly check is_simple/is_simplicial

@tscrim
Copy link
Collaborator

tscrim commented Aug 25, 2020

comment:5

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Aug 25, 2020

Reviewer: Travis Scrimshaw

@kliem
Copy link
Contributor Author

kliem commented Aug 25, 2020

comment:6

Thanks.

@vbraun
Copy link
Member

vbraun commented Aug 30, 2020

Changed branch from public/30428 to 39f3a38

@vbraun vbraun closed this as completed in 1620e0e Aug 30, 2020
This was referenced Nov 15, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: geometry p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-9.2
Development

No branches or pull requests
3 participants
@vbraun @tscrim @kliem