-
-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
is_pyramid returns a wrong certificate #30292
Labels
Milestone
Comments
comment:1
Thanks for catching this. Stupid mistake. |
New commits:
|
Branch: public/30292 |
Author: Jonathan Kliem |
Commit: |
comment:3
Perhaps there should be a _test... method that checks the certificate? |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Reviewer: Matthias Koeppe |
comment:7
Thank you. |
Changed branch from public/30292 to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The method
is_pyramid
ofCombinatorialPolyhedron
returns a wrong certificate:This bug introduced in #29189; the indexing in
_face_iter(True, 0)
is different from the indexing inVrepresentation
.CC: @jplab @kliem
Component: geometry
Keywords: polytope, combinatorialpolyhedron, is_pyramid
Author: Jonathan Kliem
Branch/Commit:
4c5c730
Reviewer: Matthias Koeppe
Issue created by migration from https://trac.sagemath.org/ticket/30292
The text was updated successfully, but these errors were encountered: