Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation warnings when unpickling pynac objects with Python 3.8 #30225

Closed
antonio-rojas opened this issue Jul 26, 2020 · 13 comments
Closed

Fix deprecation warnings when unpickling pynac objects with Python 3.8 #30225

antonio-rojas opened this issue Jul 26, 2020 · 13 comments
Labels
c: packages: standard p: major / 3 t: bug
Milestone
sage-9.2

Comments

@antonio-rojas
Copy link
Contributor

With Python 3.8, unpickling pynac objects gives a deprecation warning

DeprecationWarning: PY_SSIZE_T_CLEAN will be required for '#' formats

These are fixed in this ticket by defining PY_SSIZE_T_CLEAN where appropriate

Upstream pull request: pynac/pynac#354

Upstream: Reported upstream. No feedback yet.

CC: @jhpalmieri @mkoeppe

Component: packages: standard

Author: Antonio Rojas

Branch/Commit: ecc6f45

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/30225
@antonio-rojas antonio-rojas added this to the sage-9.2 milestone Jul 26, 2020
@antonio-rojas

This comment has been minimized.

Sign in to view
@antonio-rojas
Copy link
Contributor Author

Upstream: Reported upstream. No feedback yet.

@antonio-rojas
Copy link
Contributor Author

Author: Antonio Rojas

@antonio-rojas
Copy link
Contributor Author

Branch: u/arojas/fix_deprecation_warnings_when_unpickling_pynac_objects_with_python_3_8

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 26, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

c4769bfAdd pynac patch to fix deprecation warnings on unpickling with Python 3.8

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 26, 2020

Commit: c4769bf

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 26, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

ecc6f45Add patch

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 26, 2020

Changed commit from c4769bf to ecc6f45

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 26, 2020

comment:6

Is this safe to apply also for earlier Python versions?

@antonio-rojas
Copy link
Contributor Author

comment:7

At least for 3.7 it seems so

@jhpalmieri
Copy link
Member

comment:8

Works for me with OS X and the system Python, version 3.7.3.

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 30, 2020

Reviewer: Matthias Koeppe

@vbraun
Copy link
Member

vbraun commented Aug 7, 2020

Changed branch from u/arojas/fix_deprecation_warnings_when_unpickling_pynac_objects_with_python_3_8 to ecc6f45

@vbraun vbraun closed this as completed in 760b7d8 Aug 7, 2020
@slel slel mentioned this issue Sep 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: standard p: major / 3 t: bug
Projects
None yet
Milestone
sage-9.2
Development

No branches or pull requests
4 participants
@vbraun @jhpalmieri @mkoeppe @antonio-rojas