Support Python 3.9 #30184

slel · 2020-07-20T20:20:29Z

We should support Python 3.9 (expected to be released 2020-10-05) in Sage 9.2.

The present ticket is for the patches necessary to support Python 3.9 in addition to 3.7 and 3.8.

It does not include the actual upgrade to Python 3.9 - to test, merge #30589.

Python 3.9 release schedule
What's new in Python 3.9
Adopt the “time window-based” policy for support of Python versions from NEP 29 #30384 Adopt the “time window-based” policy for support of Python versions from NEP 29

Depends on #27754
Depends on #28012
Depends on #30590
Depends on #30053
Depends on #30595
Depends on #30576
Depends on #29500
Depends on #30546

CC: @antonio-rojas @embray @kiwifb @kliem @timokau @isuruf @jhpalmieri @mkoeppe @slel @tobihan @tscrim @jdemeyer @dimpase

Component: packages: standard

Keywords: upgrade, python

Author: Matthias Koeppe

Branch: 9d06080

Reviewer: John Palmieri, Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/30184

The text was updated successfully, but these errors were encountered:

slel · 2020-07-20T23:13:32Z

comment:1

Python 3.9.0.beta5, the last of five planned beta release previews,
was released on 2020-07-20.

https://www.python.org/downloads/release/python-390b5/

It would be nice to test and report any issues to the Python bug tracker.

jhpalmieri · 2020-07-20T23:17:26Z

comment:2

I can't even get 3.8 to work (#27754). :(

slel · 2020-08-11T23:16:11Z

comment:3

Python 3.9.0 is almost ready, with 3.9.0rc1,
the penultimate release preview, released.

https://www.python.org/downloads/release/python-390rc1/

mkoeppe · 2020-08-17T18:48:09Z

Dependencies: #27754

mkoeppe · 2020-08-20T23:11:48Z

Changed dependencies from #27754 to #27754, #28012

slel · 2020-09-17T16:48:40Z

comment:7

Python 3.9.0rc2 announced today on python-announce:

Python 3.9.0 is almost ready. This release, 3.9.0rc2,
is the last planned preview before the final release
of Python 3.9.0 on 2020-10-05. Get it here:

https://www.python.org/downloads/release/python-390rc2/

In the mean time, we strongly encourage maintainers of
third-party Python projects to prepare their projects
for 3.9 compatibility during this phase. As always,
report any issues to the Python bug tracker
https://bugs.python.org/.

mkoeppe · 2020-09-17T18:58:58Z

comment:9

With #30589 (Python 3.9.0rc2), the build goes smoothly up to here:

[sagelib-9.2.beta12] [1/1] gcc -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -Wno-unused -I/Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src -I/Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/ext -I/Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/local/include/python3.9 -I/Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/local/lib/python3.9/site-packages/numpy/core/include -Ibuild/cythonized -I/Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/local/include/python3.9 -c build/cythonized/sage/cpython/debug.c -o build/temp.macosx-10.9-x86_64-3.9/build/cythonized/sage/cpython/debug.o -fno-strict-aliasing -DCYTHON_CLINE_IN_TRACEBACK=1 -std=c99
[sagelib-9.2.beta12] In file included from build/cythonized/sage/cpython/debug.c:1446:
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:188:18: error: no member named 'tp_print' in 'struct _typeobject'
[sagelib-9.2.beta12]     attr_pointer(tp_print);
[sagelib-9.2.beta12]     ~~~~~~~~~~~~~^~~~~~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:123:24: note: expanded from macro 'attr_pointer'
[sagelib-9.2.beta12]     attr_pointer_value(attr);
[sagelib-9.2.beta12]     ~~~~~~~~~~~~~~~~~~~^~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:119:65: note: expanded from macro 'attr_pointer_value'
[sagelib-9.2.beta12] #define attr_pointer_value(attr) subattr_pointer_value(tp_name, attr);
[sagelib-9.2.beta12]                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:86:32: note: expanded from macro 'subattr_pointer_value'
[sagelib-9.2.beta12]     pointer_check_constant(tp->attr, NULL) \
[sagelib-9.2.beta12]                            ~~  ^
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:78:9: note: expanded from macro 'pointer_check_constant'
[sagelib-9.2.beta12]     if (ptr == (void*)(val)) \
[sagelib-9.2.beta12]         ^~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:188:18: error: no member named 'tp_print' in 'struct _typeobject'
[sagelib-9.2.beta12]     attr_pointer(tp_print);
[sagelib-9.2.beta12]     ~~~~~~~~~~~~~^~~~~~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:123:24: note: expanded from macro 'attr_pointer'
[sagelib-9.2.beta12]     attr_pointer_value(attr);
[sagelib-9.2.beta12]     ~~~~~~~~~~~~~~~~~~~^~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:119:65: note: expanded from macro 'attr_pointer_value'
[sagelib-9.2.beta12] #define attr_pointer_value(attr) subattr_pointer_value(tp_name, attr);
[sagelib-9.2.beta12]                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:87:37: note: expanded from macro 'subattr_pointer_value'
[sagelib-9.2.beta12]     else pointer_check_constant(tp->attr, PyType_GenericAlloc) \
[sagelib-9.2.beta12]                                 ~~  ^
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:78:9: note: expanded from macro 'pointer_check_constant'
[sagelib-9.2.beta12]     if (ptr == (void*)(val)) \
[sagelib-9.2.beta12]         ^~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:188:18: error: no member named 'tp_print' in 'struct _typeobject'
[sagelib-9.2.beta12]     attr_pointer(tp_print);
[sagelib-9.2.beta12]     ~~~~~~~~~~~~~^~~~~~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:123:24: note: expanded from macro 'attr_pointer'
[sagelib-9.2.beta12]     attr_pointer_value(attr);
[sagelib-9.2.beta12]     ~~~~~~~~~~~~~~~~~~~^~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:119:65: note: expanded from macro 'attr_pointer_value'
[sagelib-9.2.beta12] #define attr_pointer_value(attr) subattr_pointer_value(tp_name, attr);
[sagelib-9.2.beta12]                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:88:37: note: expanded from macro 'subattr_pointer_value'
[sagelib-9.2.beta12]     else pointer_check_constant(tp->attr, PyType_GenericNew) \
[sagelib-9.2.beta12]                                 ~~  ^
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:78:9: note: expanded from macro 'pointer_check_constant'
[sagelib-9.2.beta12]     if (ptr == (void*)(val)) \
[sagelib-9.2.beta12]         ^~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:188:18: error: no member named 'tp_print' in 'struct _typeobject'
[sagelib-9.2.beta12]     attr_pointer(tp_print);
[sagelib-9.2.beta12]     ~~~~~~~~~~~~~^~~~~~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:123:24: note: expanded from macro 'attr_pointer'
[sagelib-9.2.beta12]     attr_pointer_value(attr);
[sagelib-9.2.beta12]     ~~~~~~~~~~~~~~~~~~~^~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:119:65: note: expanded from macro 'attr_pointer_value'
[sagelib-9.2.beta12] #define attr_pointer_value(attr) subattr_pointer_value(tp_name, attr);
[sagelib-9.2.beta12]                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:89:37: note: expanded from macro 'subattr_pointer_value'
[sagelib-9.2.beta12]     else pointer_check_constant(tp->attr, PyObject_Del) \
[sagelib-9.2.beta12]                                 ~~  ^
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:78:9: note: expanded from macro 'pointer_check_constant'
[sagelib-9.2.beta12]     if (ptr == (void*)(val)) \
[sagelib-9.2.beta12]         ^~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:188:18: error: no member named 'tp_print' in 'struct _typeobject'
[sagelib-9.2.beta12]     attr_pointer(tp_print);
[sagelib-9.2.beta12]     ~~~~~~~~~~~~~^~~~~~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:123:24: note: expanded from macro 'attr_pointer'
[sagelib-9.2.beta12]     attr_pointer_value(attr);
[sagelib-9.2.beta12]     ~~~~~~~~~~~~~~~~~~~^~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:119:65: note: expanded from macro 'attr_pointer_value'
[sagelib-9.2.beta12] #define attr_pointer_value(attr) subattr_pointer_value(tp_name, attr);
[sagelib-9.2.beta12]                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:90:37: note: expanded from macro 'subattr_pointer_value'
[sagelib-9.2.beta12]     else pointer_check_constant(tp->attr, PyObject_GC_Del) \
[sagelib-9.2.beta12]                                 ~~  ^
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:78:9: note: expanded from macro 'pointer_check_constant'
[sagelib-9.2.beta12]     if (ptr == (void*)(val)) \
[sagelib-9.2.beta12]         ^~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:188:18: error: no member named 'tp_print' in 'struct _typeobject'
[sagelib-9.2.beta12]     attr_pointer(tp_print);
[sagelib-9.2.beta12]     ~~~~~~~~~~~~~^~~~~~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:123:24: note: expanded from macro 'attr_pointer'
[sagelib-9.2.beta12]     attr_pointer_value(attr);
[sagelib-9.2.beta12]     ~~~~~~~~~~~~~~~~~~~^~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:119:65: note: expanded from macro 'attr_pointer_value'
[sagelib-9.2.beta12] #define attr_pointer_value(attr) subattr_pointer_value(tp_name, attr);
[sagelib-9.2.beta12]                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:91:37: note: expanded from macro 'subattr_pointer_value'
[sagelib-9.2.beta12]     else pointer_check_constant(tp->attr, PyObject_GenericGetAttr) \
[sagelib-9.2.beta12]                                 ~~  ^
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:78:9: note: expanded from macro 'pointer_check_constant'
[sagelib-9.2.beta12]     if (ptr == (void*)(val)) \
[sagelib-9.2.beta12]         ^~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:188:18: error: no member named 'tp_print' in 'struct _typeobject'
[sagelib-9.2.beta12]     attr_pointer(tp_print);
[sagelib-9.2.beta12]     ~~~~~~~~~~~~~^~~~~~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:123:24: note: expanded from macro 'attr_pointer'
[sagelib-9.2.beta12]     attr_pointer_value(attr);
[sagelib-9.2.beta12]     ~~~~~~~~~~~~~~~~~~~^~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:119:65: note: expanded from macro 'attr_pointer_value'
[sagelib-9.2.beta12] #define attr_pointer_value(attr) subattr_pointer_value(tp_name, attr);
[sagelib-9.2.beta12]                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:92:37: note: expanded from macro 'subattr_pointer_value'
[sagelib-9.2.beta12]     else pointer_check_constant(tp->attr, PyObject_GenericSetAttr) \
[sagelib-9.2.beta12]                                 ~~  ^
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:78:9: note: expanded from macro 'pointer_check_constant'
[sagelib-9.2.beta12]     if (ptr == (void*)(val)) \
[sagelib-9.2.beta12]         ^~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:188:18: error: no member named 'tp_print' in 'struct _typeobject'
[sagelib-9.2.beta12]     attr_pointer(tp_print);
[sagelib-9.2.beta12]     ~~~~~~~~~~~~~^~~~~~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:123:24: note: expanded from macro 'attr_pointer'
[sagelib-9.2.beta12]     attr_pointer_value(attr);
[sagelib-9.2.beta12]     ~~~~~~~~~~~~~~~~~~~^~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:119:65: note: expanded from macro 'attr_pointer_value'
[sagelib-9.2.beta12] #define attr_pointer_value(attr) subattr_pointer_value(tp_name, attr);
[sagelib-9.2.beta12]                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:93:37: note: expanded from macro 'subattr_pointer_value'
[sagelib-9.2.beta12]     else pointer_check_constant(tp->attr, _Py_HashPointer) \
[sagelib-9.2.beta12]                                 ~~  ^
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:78:9: note: expanded from macro 'pointer_check_constant'
[sagelib-9.2.beta12]     if (ptr == (void*)(val)) \
[sagelib-9.2.beta12]         ^~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:188:18: error: no member named 'tp_print' in 'struct _typeobject'
[sagelib-9.2.beta12]     attr_pointer(tp_print);
[sagelib-9.2.beta12]     ~~~~~~~~~~~~~^~~~~~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:123:24: note: expanded from macro 'attr_pointer'
[sagelib-9.2.beta12]     attr_pointer_value(attr);
[sagelib-9.2.beta12]     ~~~~~~~~~~~~~~~~~~~^~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:119:65: note: expanded from macro 'attr_pointer_value'
[sagelib-9.2.beta12] #define attr_pointer_value(attr) subattr_pointer_value(tp_name, attr);
[sagelib-9.2.beta12]                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:94:37: note: expanded from macro 'subattr_pointer_value'
[sagelib-9.2.beta12]     else pointer_check_constant(tp->attr, PyObject_HashNotImplemented) \
[sagelib-9.2.beta12]                                 ~~  ^
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:78:9: note: expanded from macro 'pointer_check_constant'
[sagelib-9.2.beta12]     if (ptr == (void*)(val)) \
[sagelib-9.2.beta12]         ^~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:188:18: error: no member named 'tp_print' in 'struct _typeobject'
[sagelib-9.2.beta12]     attr_pointer(tp_print);
[sagelib-9.2.beta12]     ~~~~~~~~~~~~~^~~~~~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:123:24: note: expanded from macro 'attr_pointer'
[sagelib-9.2.beta12]     attr_pointer_value(attr);
[sagelib-9.2.beta12]     ~~~~~~~~~~~~~~~~~~~^~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:119:65: note: expanded from macro 'attr_pointer_value'
[sagelib-9.2.beta12] #define attr_pointer_value(attr) subattr_pointer_value(tp_name, attr);
[sagelib-9.2.beta12]                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:95:37: note: expanded from macro 'subattr_pointer_value'
[sagelib-9.2.beta12]     else pointer_check_constant(tp->attr, subtype_traverse) \
[sagelib-9.2.beta12]                                 ~~  ^
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:78:9: note: expanded from macro 'pointer_check_constant'
[sagelib-9.2.beta12]     if (ptr == (void*)(val)) \
[sagelib-9.2.beta12]         ^~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:188:18: error: no member named 'tp_print' in 'struct _typeobject'
[sagelib-9.2.beta12]     attr_pointer(tp_print);
[sagelib-9.2.beta12]     ~~~~~~~~~~~~~^~~~~~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:123:24: note: expanded from macro 'attr_pointer'
[sagelib-9.2.beta12]     attr_pointer_value(attr);
[sagelib-9.2.beta12]     ~~~~~~~~~~~~~~~~~~~^~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:119:65: note: expanded from macro 'attr_pointer_value'
[sagelib-9.2.beta12] #define attr_pointer_value(attr) subattr_pointer_value(tp_name, attr);
[sagelib-9.2.beta12]                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:96:37: note: expanded from macro 'subattr_pointer_value'
[sagelib-9.2.beta12]     else pointer_check_constant(tp->attr, subtype_clear) \
[sagelib-9.2.beta12]                                 ~~  ^
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:78:9: note: expanded from macro 'pointer_check_constant'
[sagelib-9.2.beta12]     if (ptr == (void*)(val)) \
[sagelib-9.2.beta12]         ^~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:188:18: error: no member named 'tp_print' in 'struct _typeobject'
[sagelib-9.2.beta12]     attr_pointer(tp_print);
[sagelib-9.2.beta12]     ~~~~~~~~~~~~~^~~~~~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:123:24: note: expanded from macro 'attr_pointer'
[sagelib-9.2.beta12]     attr_pointer_value(attr);
[sagelib-9.2.beta12]     ~~~~~~~~~~~~~~~~~~~^~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:119:65: note: expanded from macro 'attr_pointer_value'
[sagelib-9.2.beta12] #define attr_pointer_value(attr) subattr_pointer_value(tp_name, attr);
[sagelib-9.2.beta12]                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:97:37: note: expanded from macro 'subattr_pointer_value'
[sagelib-9.2.beta12]     else pointer_check_constant(tp->attr, subtype_dealloc) \
[sagelib-9.2.beta12]                                 ~~  ^
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:78:9: note: expanded from macro 'pointer_check_constant'
[sagelib-9.2.beta12]     if (ptr == (void*)(val)) \
[sagelib-9.2.beta12]         ^~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:188:18: error: no member named 'tp_print' in 'struct _typeobject'
[sagelib-9.2.beta12]     attr_pointer(tp_print);
[sagelib-9.2.beta12]     ~~~~~~~~~~~~~^~~~~~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:123:24: note: expanded from macro 'attr_pointer'
[sagelib-9.2.beta12]     attr_pointer_value(attr);
[sagelib-9.2.beta12]     ~~~~~~~~~~~~~~~~~~~^~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:119:65: note: expanded from macro 'attr_pointer_value'
[sagelib-9.2.beta12] #define attr_pointer_value(attr) subattr_pointer_value(tp_name, attr);
[sagelib-9.2.beta12]                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:108:39: note: expanded from macro 'subattr_pointer_value'
[sagelib-9.2.beta12]                 if (subtp->sub && tp->attr == subtp->attr) \
[sagelib-9.2.beta12]                                   ~~  ^
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:188:18: error: no member named 'tp_print' in 'struct _typeobject'
[sagelib-9.2.beta12]     attr_pointer(tp_print);
[sagelib-9.2.beta12]     ~~~~~~~~~~~~~^~~~~~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:123:24: note: expanded from macro 'attr_pointer'
[sagelib-9.2.beta12]     attr_pointer_value(attr);
[sagelib-9.2.beta12]     ~~~~~~~~~~~~~~~~~~~^~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:119:65: note: expanded from macro 'attr_pointer_value'
[sagelib-9.2.beta12] #define attr_pointer_value(attr) subattr_pointer_value(tp_name, attr);
[sagelib-9.2.beta12]                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:108:54: note: expanded from macro 'subattr_pointer_value'
[sagelib-9.2.beta12]                 if (subtp->sub && tp->attr == subtp->attr) \
[sagelib-9.2.beta12]                                               ~~~~~  ^
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:188:18: error: no member named 'tp_print' in 'struct _typeobject'
[sagelib-9.2.beta12]     attr_pointer(tp_print);
[sagelib-9.2.beta12]     ~~~~~~~~~~~~~^~~~~~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:123:24: note: expanded from macro 'attr_pointer'
[sagelib-9.2.beta12]     attr_pointer_value(attr);
[sagelib-9.2.beta12]     ~~~~~~~~~~~~~~~~~~~^~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:119:65: note: expanded from macro 'attr_pointer_value'
[sagelib-9.2.beta12] #define attr_pointer_value(attr) subattr_pointer_value(tp_name, attr);
[sagelib-9.2.beta12]                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
[sagelib-9.2.beta12] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/build/pkgs/sagelib/src/sage/cpython/debugimpl.c:117:37: note: expanded from macro 'subattr_pointer_value'
[sagelib-9.2.beta12]     if (special) printf("%p\n", tp->attr);
[sagelib-9.2.beta12]                                 ~~  ^
[sagelib-9.2.beta12] 15 errors generated.
[sagelib-9.2.beta12] error: command '/usr/bin/gcc' failed with exit code 1
[sagelib-9.2.beta12] Exception ignored in: <function Pool.__del__ at 0x1196803a0>
[sagelib-9.2.beta12] Traceback (most recent call last):
[sagelib-9.2.beta12]   File "/Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/local/lib/python3.9/multiprocessing/pool.py", line 268, in __del__
[sagelib-9.2.beta12]     self._change_notifier.put(None)
[sagelib-9.2.beta12]   File "/Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/local/lib/python3.9/multiprocessing/queues.py", line 378, in put
[sagelib-9.2.beta12]     self._writer.send_bytes(obj)
[sagelib-9.2.beta12]   File "/Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/local/lib/python3.9/multiprocessing/connection.py", line 205, in send_bytes
[sagelib-9.2.beta12]     self._send_bytes(m[offset:offset + size])
[sagelib-9.2.beta12]   File "/Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/local/lib/python3.9/multiprocessing/connection.py", line 416, in _send_bytes
[sagelib-9.2.beta12]     self._send(header + buf)
[sagelib-9.2.beta12]   File "/Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/local/lib/python3.9/multiprocessing/connection.py", line 373, in _send
[sagelib-9.2.beta12]     n = write(self._handle, buf)
[sagelib-9.2.beta12] OSError: [Errno 9] Bad file descriptor
[sagelib-9.2.beta12] 
[sagelib-9.2.beta12] real	0m7.479s
[sagelib-9.2.beta12] user	0m4.042s
[sagelib-9.2.beta12] sys	0m2.327s

mkoeppe · 2020-09-17T19:29:12Z

comment:11

There is little evidence that anyone but the author of type_debug has used this facility. Candidate for removal. Surely there must be something like this on PyPI somewhere?

mkoeppe · 2020-09-17T20:36:51Z

Changed dependencies from #27754, #28012 to #27754, #28012, #30590

mkoeppe · 2020-09-17T20:49:27Z

Branch: u/mkoeppe/support_python_3_9

mkoeppe · 2020-09-17T20:51:22Z

Commit: 0d00d0a

mkoeppe · 2020-09-17T20:51:22Z

comment:14

Deprecation warnings in docbuild:

[dochtml] <frozen importlib._bootstrap>:228: DeprecationWarning: The parser module is deprecated and will be removed in future versions of Python
[dochtml] [arithgrou] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/local/lib/python3.9/ast.py:407: DeprecationWarning: visit_NameConstant is deprecated; add visit_Constant
[dochtml] [arithgrou]   return visitor(node)
[dochtml] [plot3d   ] /Users/mkoeppe/s/sage/sage-rebasing/worktree-py39/local/lib/python3.9/ast.py:407: DeprecationWarning: visit_Str is deprecated; add visit_Constant

New commits:

`3e3c0ea`	`build/pkgs/python3: Update to 3.9.0rc2`
`8f71b29`	`src/sage/cpython/debugimpl.c: Remove python2 code`
`25b2b05`	`Merge branch 't/30590/src_sage_cpython_debugimpl_c__remove_python2_code' into t/30184/support_python_3_9`
`0d00d0a`	`src/sage/cpython/debugimpl.c: Disable _type_debug for Python 3.9`

mkoeppe · 2020-09-17T21:15:52Z

Changed dependencies from #27754, #28012, #30590 to #27754, #28012, #30590, #30053

mkoeppe · 2020-09-17T22:27:42Z

comment:16

make ptestlong also has various failures due to new warnings DeprecationWarning: visit_Str is deprecated; add visit_Constant and similar

mkoeppe · 2020-09-17T22:28:05Z

comment:17

Any warning-suppression specialists here?

jhpalmieri · 2020-09-17T22:40:30Z

comment:18

Can you add to the relevant section of src/sage/all.py? There are lines like

# scipy 1.18 introduced reprecation warnings on a number of things they are moving to
# numpy, e.g. DeprecationWarning: scipy.array is deprecated
#             and will be removed in SciPy 2.0.0, use numpy.array instead
# This affects networkx 2.2 up and including 2.4 (cf. :trac:29766)
warnings.filterwarnings('ignore', category=DeprecationWarning,
    module='.*(scipy|networkx)')

mkoeppe · 2020-09-17T22:55:27Z

comment:19

Thanks!

sagetrac-git · 2020-09-17T23:00:44Z

Changed commit from 0d00d0a to 4a8c191

sagetrac-git · 2020-09-17T23:00:44Z

Branch pushed to git repo; I updated commit sha1. New commits:

`4a8c191`	`src/sage/all.py: Filter out Python 3.9 deprecation warnings from ast`

mkoeppe · 2020-09-17T23:01:52Z

comment:21

Replying to @mkoeppe:

Deprecation warnings in docbuild:

[dochtml] <frozen importlib._bootstrap>:228: DeprecationWarning: The parser module is deprecated and will be removed in future versions of Python

This one also shows up on normal startup. Coming from here:

$ git grep 'import parser'
src/sage/symbolic/ring.pyx:import parser

(Implementation of isidentifier.)

mkoeppe · 2020-09-17T23:07:35Z

comment:22

Looks like we can simplify isidentifier now that we are py3-only, similar to https://stackoverflow.com/questions/12700893/how-to-check-if-a-string-is-a-valid-python-identifier-including-keyword-check

sagetrac-git · 2020-09-18T00:11:03Z

Changed commit from 4a8c191 to c3d0805

sagetrac-git · 2020-09-18T00:11:03Z

Branch pushed to git repo; I updated commit sha1. New commits:

`c3d0805`	`src/sage/symbolic/ring.pyx (isidentifier): Remove py2-only code, use of deprecated parser module`

sagetrac-git · 2020-09-18T00:12:02Z

Changed commit from c3d0805 to 463e90d

mkoeppe · 2020-09-29T00:53:54Z

comment:54

Thanks!

I marked it a blocker because we won't be able to release 9.2 before Python 3.9 is released and our new release would therefore already be outdated.

dimpase · 2020-09-30T09:22:36Z

comment:55

I've tested this with system Python 3.9.rc2 on Gentoo, and got

sage -t --random-seed=0 src/sage/rings/polynomial/pbori/randompoly.py
**********************************************************************
File "src/sage/rings/polynomial/pbori/randompoly.py", line 46, in sage.rings.polynomial.pbori.randompoly.?
Failed example:
    s=sparse_random_system(r, number_of_polynomials = 20, variables_per_polynomial = 3, degree=2, random_seed=123)
Expected nothing
Got:
    doctest:warning
      File "/mnt/opt/Sage/sage-clang/src/bin/sage-runtests", line 182, in <module>
        err = DC.run()
...
      File "/mnt/opt/Sage/sage-clang/local/lib/python3.9/site-packages/sage/rings/polynomial/pbori/randompoly.py", line 54, in sparse_random_system
        random_generator = Random(random_seed)
      File "/usr/lib/python3.9/random.py", line 122, in __init__
        self.seed(x)
      File "/usr/lib/python3.9/random.py", line 158, in seed
        _warn('Seeding based on hashing is deprecated\n'
      File "/usr/lib/python3.9/warnings.py", line 109, in _showwarnmsg
        sw(msg.message, msg.category, msg.filename, msg.lineno,
    :
    DeprecationWarning: Seeding based on hashing is deprecated
    since Python 3.9 and will be removed in a subsequent version. The only 
    supported seed types are: None, int, float, str, bytes, and bytearray.

and also

File "src/sage/misc/sageinspect.py", line 2275, in sage.misc.sageinspect.sage_getsourcelines
Failed example:
    sage_getsourcelines(I)
Expected:
    (...['class MPolynomialIdeal( MPolynomialIdeal_singular_repr, \\\n',
    ...)
Got:
    (['@richcmp_method\n', 'class MPolynomialIdeal( MPolynomialIdeal_singular_repr, \\\n', '                        MPolynomialIdeal_macaulay2_repr, \\\n', '  ....
...

dimpase · 2020-09-30T09:29:19Z

Changed reviewer from John Palmieri to John Palmieri, Dima Pasechnik

sagetrac-git · 2020-09-30T20:34:41Z

Changed commit from 4f7d588 to 9d06080

sagetrac-git · 2020-09-30T20:34:41Z

Branch pushed to git repo; I updated commit sha1. New commits:

`9d06080`	`src/sage/misc/sageinspect.py: Fix doctest pattern`

mkoeppe · 2020-09-30T21:45:21Z

comment:58

See comment 45.

dimpase · 2020-10-01T08:18:56Z

comment:59

Replying to @mkoeppe:

See comment 45.

oops, sorry, I was somewhat late to the party. Another problem I'm investigating is that this upgrade seems to lead to zombie Maxima and ECL processes.

dimpase · 2020-10-01T14:26:53Z

comment:60

ok, good (Zombies have nothing to do with this update)

mkoeppe · 2020-10-01T15:55:44Z

comment:61

Thanks.

vbraun · 2020-10-03T22:57:25Z

Changed branch from u/mkoeppe/support_python_3_9 to 9d06080

slel · 2020-10-08T13:39:32Z

comment:63

Replying to @kiwifb:

Replying to @mkoeppe:
Only these two remain. Perhaps "good enough for 9.2"?
sage -t --long --random-seed=0 src/sage/functions/other.py  # 1 doctest failed
sage -t --long --random-seed=0 src/sage/rings/polynomial/pbori/randompoly.py  # 1 doctest failed
I can take ownership of the pbori one, I'll see what I can do.

Should a follow-up ticket for each of these two issues be opened?

Meta-ticket for all Python 3.9 issues?

Too early for a ticket for Python 3.10 support? Python 3.10.0a1 is out:

https://www.python.org/downloads/release/python-3100a1/

slel · 2020-10-08T13:39:32Z

Changed commit from 9d06080 to none

mkoeppe · 2020-10-13T20:49:14Z

comment:64

Replying to @slel:

Replying to @kiwifb:
Replying to @mkoeppe:
Only these two remain. Perhaps "good enough for 9.2"?
sage -t --long --random-seed=0 src/sage/functions/other.py  # 1 doctest failed
sage -t --long --random-seed=0 src/sage/rings/polynomial/pbori/randompoly.py  # 1 doctest failed
I can take ownership of the pbori one, I'll see what I can do.
Should a follow-up ticket for each of these two issues be opened?

Yes please

Meta-ticket for all Python 3.9 issues?

I don't think this is necessary

Too early for a ticket for Python 3.10 support? Python 3.10.0a1 is out:

https://www.python.org/downloads/release/python-3100a1/

Sure, please open a ticket

slel · 2020-10-13T22:06:04Z

comment:65

Follow-up tickets:

Adapt to float factorial deprecation in Python 3.9 #30764: Adapt to float factorial deprecation in Python 3.9
Adapt to deprecation of seeding based on hashing in Python 3.9 #30765: Adapt to deprecation of seeding based on hashing in Python 3.9
Experimental support for Python 3.10 in Sage 9.5 #30766: Support Python 3.10
Update Python to 3.10.x #30767: Test ticket: Python 3.10 development releases

dimpase · 2020-10-20T16:16:16Z

comment:66

you might have seen this:
python/cpython#22670 - a critical incompatibility with pybind11

dimpase · 2020-10-20T16:21:53Z

comment:67

From https://pybind11.readthedocs.io/en/latest/

Warning

Combining older versions of pybind11 (< 2.6.0) with the brand-new Python 3.9.0 will trigger undefined behavior that typically manifests as crashes during interpreter shutdown (but could also destroy your data. You have been warned.)

We recommend that you wait for Python 3.9.1 slated for release in December, which will include a fix that resolves this problem. In the meantime, please update to the latest version of pybind11 (2.6.0 or newer), which includes a temporary workaround specifically when Python 3.9.0 is detected at runtime.

should we hold off 3.9.0 (in spkg-configure.m4 of python3) ?

mkoeppe · 2020-10-20T17:47:26Z

comment:68

We can do the pybind11 upgrade

mkoeppe · 2020-10-20T17:50:07Z

comment:69

Replying to @mkoeppe:

We can do the pybind11 upgrade

Created #30803 for this

slel added this to the sage-9.3 milestone Jul 20, 2020

slel added c: packages: standard labels Jul 20, 2020

This comment has been minimized.

Sign in to view

dimpase added s: needs work and removed s: positive review labels Sep 30, 2020

mkoeppe added s: needs review and removed s: needs work labels Sep 30, 2020

dimpase added s: positive review and removed s: needs review labels Oct 1, 2020

vbraun removed the s: positive review label Oct 3, 2020

vbraun closed this as completed in 91eac29 Oct 3, 2020

This was referenced Sep 11, 2020

Upgrade: Python 3.8.5 #27754

Closed

Adapt to float factorial deprecation in Python 3.9 #30764

Closed

Adapt to deprecation of seeding based on hashing in Python 3.9 #30765

Closed

Experimental support for Python 3.10 in Sage 9.5 #30766

Closed

Support Python 3.9 #30184

Support Python 3.9 #30184

Comments

slel commented Jul 20, 2020

slel commented Jul 20, 2020

jhpalmieri commented Jul 20, 2020

slel commented Aug 11, 2020

This comment has been minimized.

mkoeppe commented Aug 17, 2020

This comment has been minimized.

mkoeppe commented Aug 20, 2020

slel commented Sep 17, 2020

This comment has been minimized.

mkoeppe commented Sep 17, 2020

mkoeppe commented Sep 17, 2020

mkoeppe commented Sep 17, 2020

mkoeppe commented Sep 17, 2020

mkoeppe commented Sep 17, 2020

mkoeppe commented Sep 17, 2020

mkoeppe commented Sep 17, 2020

mkoeppe commented Sep 17, 2020

mkoeppe commented Sep 17, 2020

jhpalmieri commented Sep 17, 2020

mkoeppe commented Sep 17, 2020

sagetrac-git mannequin commented Sep 17, 2020

sagetrac-git mannequin commented Sep 17, 2020

mkoeppe commented Sep 17, 2020

mkoeppe commented Sep 17, 2020

sagetrac-git mannequin commented Sep 18, 2020

sagetrac-git mannequin commented Sep 18, 2020

sagetrac-git mannequin commented Sep 18, 2020

mkoeppe commented Sep 29, 2020

dimpase commented Sep 30, 2020

dimpase commented Sep 30, 2020

sagetrac-git mannequin commented Sep 30, 2020

sagetrac-git mannequin commented Sep 30, 2020

mkoeppe commented Sep 30, 2020

dimpase commented Oct 1, 2020

dimpase commented Oct 1, 2020

mkoeppe commented Oct 1, 2020

vbraun commented Oct 3, 2020

slel commented Oct 8, 2020

slel commented Oct 8, 2020

mkoeppe commented Oct 13, 2020

slel commented Oct 13, 2020

dimpase commented Oct 20, 2020

dimpase commented Oct 20, 2020

mkoeppe commented Oct 20, 2020

mkoeppe commented Oct 20, 2020