Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1 internet doctest failing in combinat/species/library.py + combinat/tutorial.py #30020

Closed
seblabbe opened this issue Jun 29, 2020 · 15 comments
Closed

Comments

@seblabbe
Copy link
Contributor

With SageMath version 9.2.beta2, Release Date: 2020-06-26, the command

sage -t --optional=sage,internet src/sage/combinat/species/library.py src/sage/combinat/tutorial.py

gives

Doctesting 2 files.
sage -t src/sage/combinat/species/library.py
**********************************************************************
File "src/sage/combinat/species/library.py", line 104, in sage.combinat.species.library.BinaryTreeSpecies
Failed example:
    oeis(seq)[0]                              # optional -- internet
Expected:
    A000108: Catalan numbers: C(n) = binomial(2n,n)/(n+1) = (2n)!/(n!(n+1)!). Also called Segner numbers.
Got:
    A000108: Catalan numbers: C(n) = binomial(2n,n)/(n+1) = (2n)!/(n!(n+1)!).
**********************************************************************
1 item had failures:
   1 of  10 in sage.combinat.species.library.BinaryTreeSpecies
    [23 tests, 1 failure, 3.88 s]
sage -t src/sage/combinat/tutorial.py
**********************************************************************
File "src/sage/combinat/tutorial.py", line 224, in sage.combinat.tutorial
Failed example:
    oeis([1,1,2,5,14])                            # optional -- internet
Expected:
    0: A000108: Catalan numbers: C(n) = binomial(2n,n)/(n+1) = (2n)!/(n!(n+1)!). Also called Segner numbers.
    1: ...
    2: ...
Got:
    0: A000108: Catalan numbers: C(n) = binomial(2n,n)/(n+1) = (2n)!/(n!(n+1)!).
    1: A022562: Number of connected claw-free unlabeled graphs on n nodes.
    2: A124302: Number of set partitions with at most 3 blocks; number of Dyck paths of height at most 4; dimension of space of symmetric polynomials in 3 noncommuting variables.
**********************************************************************
1 item had failures:
   1 of 245 in sage.combinat.tutorial
    [244 tests, 1 failure, 6.98 s]
----------------------------------------------------------------------
sage -t src/sage/combinat/species/library.py  # 1 doctest failed
sage -t src/sage/combinat/tutorial.py  # 1 doctest failed
----------------------------------------------------------------------

Component: combinatorics

Author: Sébastien Labbé

Branch/Commit: 9b13210

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/30020

@seblabbe seblabbe added this to the sage-9.2 milestone Jun 29, 2020
@seblabbe

This comment has been minimized.

@seblabbe seblabbe changed the title 1 internet doctest failing in combinat/species/library.py + combinat/tutorial.py 3 internet oeis doctests failing in combinat Jun 29, 2020
@seblabbe
Copy link
Contributor Author

comment:2

removing beaver failing doctest, because it was already dealt in #29787

@seblabbe

This comment has been minimized.

@seblabbe seblabbe changed the title 3 internet oeis doctests failing in combinat 1 internet doctest failing in combinat/species/library.py + combinat/tutorial.py Jun 29, 2020
@seblabbe
Copy link
Contributor Author

Author: Sébastien Labbé

@seblabbe
Copy link
Contributor Author

Commit: cdfc3cd

@seblabbe
Copy link
Contributor Author

New commits:

cdfc3cd30020: fixing doctests depending on OEIS (Catalan numbers)

@seblabbe
Copy link
Contributor Author

Branch: u/slabbe/30020

@seblabbe

This comment has been minimized.

@tscrim
Copy link
Collaborator

tscrim commented Jul 1, 2020

comment:4

It might be good to adopt a similar strategy to #29787 and add some ... to hopefully make sure this doesn't happen again from other OEIS changes.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 6, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

9b1321030020: making doctests more robust after reviewer comment

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 6, 2020

Changed commit from cdfc3cd to 9b13210

@seblabbe
Copy link
Contributor Author

seblabbe commented Jul 6, 2020

comment:6

Ok, I think this is now more robust.

@tscrim
Copy link
Collaborator

tscrim commented Jul 6, 2020

comment:7

Thanks. LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Jul 6, 2020

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Jul 10, 2020

Changed branch from u/slabbe/30020 to 9b13210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants