Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make plot doctests ready for random seeds #29986

Closed
kliem opened this issue Jun 24, 2020 · 14 comments
Closed

Make plot doctests ready for random seeds #29986

kliem opened this issue Jun 24, 2020 · 14 comments
Labels
c: doctest framework r: duplicate t: enhancement

Comments

@kliem
Copy link
Contributor

kliem commented Jun 24, 2020

This ticket makes

sage -t --long --random-seed=n src/sage/plot/

pass for different values n than just 0.

This was already taken care of by #30176.

Component: doctest framework

Reviewer: Dave Morris

Issue created by migration from https://trac.sagemath.org/ticket/29986
@kliem kliem added this to the sage-9.2 milestone Jun 24, 2020
@kliem
Copy link
Contributor Author

kliem commented Jun 24, 2020

Author: Jonathan Kliem

@kliem
Copy link
Contributor Author

kliem commented Jun 24, 2020

Commit: 37a9e1c

@kliem
Copy link
Contributor Author

kliem commented Jun 24, 2020

Branch: public/29986

@kliem
Copy link
Contributor Author

kliem commented Jun 24, 2020

New commits:

da1c6bestart from a "random" random seed for doctesting
b7b836dmake random seed reproducible
eedbe5edocument random_seed
998b1b9default random seed 0 for now
1d7b00edash instead of underscore for command line options
37a9e1cmake plot fuzz ready

@kliem
Copy link
Contributor Author

kliem commented Jul 12, 2020

comment:2

Merge conflict.

I also need to go through it again and check I respected the design decision in #29935.

@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Sep 5, 2020
@kliem
Copy link
Contributor Author

kliem commented Sep 18, 2020

comment:4

It appears that without a solution to #29954, this task might be infeasible (unless you want to mark every single doctest counting the graphic primitives as known bug).

@DaveWitteMorris
Copy link
Member

Reviewer: Dave Morris

@DaveWitteMorris
Copy link
Member

comment:5

This can be closed as a duplicate of #30176, because commit 73af14a of that ticket adjusted the tolerance of these two doctests. I tried a dozen different seeds and didn't get any doctest failures in the plot directory.

@DaveWitteMorris DaveWitteMorris removed this from the sage-9.3 milestone Jan 21, 2021
@kliem
Copy link
Contributor Author

kliem commented Jan 21, 2021

Changed dependencies from #29962 to none

@kliem
Copy link
Contributor Author

kliem commented Jan 21, 2021

Changed author from Jonathan Kliem to none

@kliem
Copy link
Contributor Author

kliem commented Jan 21, 2021

comment:6

Agreed.

@kliem
Copy link
Contributor Author

kliem commented Jan 21, 2021

Changed commit from 37a9e1c to none

@kliem

This comment has been minimized.

Sign in to view
@kliem
Copy link
Contributor Author

kliem commented Jan 21, 2021

Changed branch from public/29986 to none

@dimpase dimpase mentioned this issue Oct 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: doctest framework r: duplicate t: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fchapoton @mkoeppe @kliem @DaveWitteMorris