Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make documentation doctests ready for random seeds #29981

Closed
kliem opened this issue Jun 24, 2020 · 15 comments
Closed

Make documentation doctests ready for random seeds #29981

kliem opened this issue Jun 24, 2020 · 15 comments

Comments

@kliem
Copy link
Contributor

kliem commented Jun 24, 2020

This ticket makes

sage -t --long --random-seed=n src/doc/

pass for different values n than just 0.

Depends on #29962

Component: doctest framework

Author: Jonathan Kliem

Branch/Commit: 0e062d5

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/29981

@kliem kliem added this to the sage-9.2 milestone Jun 24, 2020
@kliem
Copy link
Contributor Author

kliem commented Jun 24, 2020

Author: Jonathan Kliem

@kliem
Copy link
Contributor Author

kliem commented Jun 24, 2020

Branch: public/29981

@kliem
Copy link
Contributor Author

kliem commented Jun 24, 2020

New commits:

da1c6bestart from a "random" random seed for doctesting
b7b836dmake random seed reproducible
eedbe5edocument random_seed
998b1b9default random seed 0 for now
1d7b00edash instead of underscore for command line options
f1066b4make documentation fuzz ready

@kliem
Copy link
Contributor Author

kliem commented Jun 24, 2020

Commit: f1066b4

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 29, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

90cb2f3Merge branch 'develop' of git://trac.sagemath.org/sage into public/29981

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 29, 2020

Changed commit from f1066b4 to 90cb2f3

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 29, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

ac45e07random event is valid now

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 29, 2020

Changed commit from 90cb2f3 to ac45e07

@kliem
Copy link
Contributor Author

kliem commented Jul 12, 2020

comment:4

Merge conflict.

I also need to go through it again and check I respected the design decision in #29935.

@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Sep 5, 2020
@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 13, 2021

comment:6

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Feb 13, 2021
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 1, 2021

Changed commit from ac45e07 to 0e062d5

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 1, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

0e062d5make documentation ready for random seeds

@dimpase
Copy link
Member

dimpase commented Jun 3, 2021

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Jun 3, 2021

comment:9

lgtm

@vbraun
Copy link
Member

vbraun commented Jun 19, 2021

Changed branch from public/29981 to 0e062d5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants