Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make graphs doctests ready for random seeds #29965

Closed
kliem opened this issue Jun 24, 2020 · 28 comments
Closed

Make graphs doctests ready for random seeds #29965

kliem opened this issue Jun 24, 2020 · 28 comments
Labels
c: doctest framework p: major / 3 t: enhancement
Milestone
sage-9.2

Comments

@kliem
Copy link
Contributor

kliem commented Jun 24, 2020

This ticket makes

sage -t --long --random-seed=n src/sage/graphs/

pass for different values n than just 0.

Depends on #29962
Depends on #29958

Component: doctest framework

Author: Jonathan Kliem

Branch/Commit: e8a9a90

Reviewer: David Coudert

Issue created by migration from https://trac.sagemath.org/ticket/29965
@kliem kliem added this to the sage-9.2 milestone Jun 24, 2020
@kliem
Copy link
Contributor Author

kliem commented Jun 24, 2020

Branch: public/29965

@kliem
Copy link
Contributor Author

kliem commented Jun 24, 2020

Commit: 3f85d34

@kliem
Copy link
Contributor Author

kliem commented Jun 24, 2020

New commits:

da1c6bestart from a "random" random seed for doctesting
b7b836dmake random seed reproducible
eedbe5edocument random_seed
998b1b9default random seed 0 for now
1d7b00edash instead of underscore for command line options
964588fmake graphs ready for fuzz doctests
3f85d34failing doctest due to missing sort

@kliem
Copy link
Contributor Author

kliem commented Jun 24, 2020

Dependencies: #29962

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 24, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

7dd4282bug in connectivity

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 24, 2020

Changed commit from 3f85d34 to 7dd4282

@kliem
Copy link
Contributor Author

kliem commented Jul 9, 2020

Changed branch from public/29965 to public/29965-reb

@kliem
Copy link
Contributor Author

kliem commented Jul 9, 2020

Changed commit from 7dd4282 to none

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 9, 2020

Commit: 57a3302

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 9, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

da1c6bestart from a "random" random seed for doctesting
b7b836dmake random seed reproducible
eedbe5edocument random_seed
998b1b9default random seed 0 for now
1d7b00edash instead of underscore for command line options
b3ea6efMerge branch 'public/29962' of git://trac.sagemath.org/sage into public/29965-reb
89d6bccmake graphs ready for fuzz doctests
7dc9cd5failing doctest due to missing sort
57a3302bug in connectivity

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 9, 2020

Changed commit from 57a3302 to e9204fa

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 9, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

e9204faimprovements of random tests

@dcoudert
Copy link
Contributor

comment:7

in sage/graphs/connectivity.pyx, you added # known bug, but the issue is fixed in #29958.

in sage/graphs/generators/random.py it might be better to do

-    EXAMPLES: We show the edge list of a random graph with 3 backbone
+    EXAMPLES:
+
+    We check a random graph with 12 backbone
     nodes and probabilities `p = 0.7` and `q = 0.3`::

@kliem
Copy link
Contributor Author

kliem commented Jul 10, 2020

Changed dependencies from #29962 to #29962, #29958

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 10, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

07ce116trac #29958: fix
5b46764Merge branch 'public/graphs/29958_sap' of git://trac.sagemath.org/sage into public/29965-reb
5d0b277remove known bug for fixed bug
f770315improved documentation style

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 10, 2020

Changed commit from e9204fa to f770315

@dcoudert
Copy link
Contributor

Reviewer: David Coudert

@dcoudert
Copy link
Contributor

comment:10

LGTM.

@kliem
Copy link
Contributor Author

kliem commented Jul 10, 2020

comment:11

Thank you.

@kliem
Copy link
Contributor Author

kliem commented Jul 12, 2020

comment:12

Merge conflict.

@kliem
Copy link
Contributor Author

kliem commented Jul 12, 2020

comment:13

Fixed merge conflict.

@kliem
Copy link
Contributor Author

kliem commented Jul 12, 2020

Changed branch from public/29965-reb to public/29965-reb2

@kliem
Copy link
Contributor Author

kliem commented Jul 12, 2020

Changed commit from f770315 to e8a9a90

@kliem
Copy link
Contributor Author

kliem commented Jul 12, 2020

New commits:

b31e2d5Merge branch 'public/29962' of git://trac.sagemath.org/sage into public/29962-reb
2f30dd9small fixes
b62f781doctests do not start from a random seed by default yet
1d99129fix merge conflict
e8a9a90merged in public/29965-reb

@dcoudert
Copy link
Contributor

comment:15

Successfully tested over 9.2.beta5.

@kliem
Copy link
Contributor Author

kliem commented Jul 13, 2020

comment:16

Thanks again.

@vbraun
Copy link
Member

vbraun commented Jul 15, 2020

comment:17

Merge conflict

@vbraun
Copy link
Member

vbraun commented Jul 19, 2020

Changed branch from public/29965-reb2 to e8a9a90

@vbraun vbraun closed this as completed in 5ffdbc5 Jul 19, 2020
@dimpase dimpase mentioned this issue Oct 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: doctest framework p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.2
Development

No branches or pull requests
3 participants
@vbraun @dcoudert @kliem