Deprecate deprecated sage-cython script harder, remove use of it in the main sage script

[jhpalmieri]

The script sage-cython has been deprecated for about 18 months, so let's remove its use within sage.

Depends on #29111

Component: scripts

Author: John Palmieri

Branch/Commit: 648e327

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/29923

[jhpalmieri]

Branch: u/jhpalmieri/remove-sage-cython

[jhpalmieri]

Last 10 new commits:

55c5680	src/bin/sage: Move parts of the help message to sage-site
885092e	src/doc/bootstrap: Generate src/doc/en/reference/repl/options.txt
05ba86a	Merge branch 't/29884/src_doc_bootstrap__generate_src_doc_en_reference_repl_options_rst' into t/29111/specify_a_subset_of_sage_command_line_options_that_are_supported_by_sagelib___rather_than_sage_the_distribution
72c7e23	src/doc/en/reference/repl/options.rst: Replace copypasta by include of generated file options.txt
e9a883d	trac 29111: revising "sage --advanced" message.
5dca421	trac 29111: more reorganization of "sage --advanced" message
8f0ee05	trac 29111: delete sage-fix-pkg-checksums
21fc231	trac 29111: re "sage --advanced" message:
875940d	trac 29111: more tinkering. Fix doctests in tests/cmdline.py.
8c9b79b	trac 29923: remove the deprecated sage-cython script

[jhpalmieri]

Commit: 8c9b79b

[mkoeppe]

comment:3

This script has a good chance of being used in user package install scripts. So I would suggest to do the removal a little later...

[jhpalmieri]

comment:4

What about this part, at least:

diff --git a/build/bin/sage-site b/build/bin/sage-site
index 6daa094..8de96ce 100755
--- a/build/bin/sage-site
+++ b/build/bin/sage-site
@@ -200,7 +200,7 @@ fi
 
 if [ "$1" = "-cython" -o "$1" = '--cython' -o "$1" = '-pyrex' -o "$1" = "--pyrex" ]; then
     shift
-    exec sage-cython "$@"
+    exec cython "$@"
 fi
 
 if [ "$1" = '-gap' -o "$1" = '--gap' ]; then

plus maybe a deprecation warning whenever sage-cython is called?

[mkoeppe]

comment:5

Sure, sounds good

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

4a3d36e	Move 'sage -app' back to src/bin/sage
0f51881	trac 29923: remove use of sage-cython in main sage script,

[sagetrac-git]

Changed commit from 8c9b79b to 0f51881

[jhpalmieri]

comment:7

Okay, done.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

648e327

trac 29923: remove use of sage-cython in main sage script,

[sagetrac-git]

Changed commit from 0f51881 to 648e327

[mkoeppe]

Reviewer: Matthias Koeppe

[vbraun]

Changed branch from u/jhpalmieri/remove-sage-cython to 648e327