Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test method is_combinatorially_isomorphic #29908

Closed
kliem opened this issue Jun 19, 2020 · 14 comments
Closed

Test method is_combinatorially_isomorphic #29908

kliem opened this issue Jun 19, 2020 · 14 comments
Labels
c: geometry p: major / 3 t: enhancement
Milestone
sage-9.2

Comments

@kliem
Copy link
Contributor

kliem commented Jun 19, 2020

We add a method that tests is_combinatorially_isomorphic.

Depends on #29898
Depends on #29899
Depends on #29903

CC: @jplab @LaisRast

Component: geometry

Keywords: polyhedra, test suite

Author: Jonathan Kliem

Branch/Commit: a6d49a1

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/29908
@kliem kliem added this to the sage-9.2 milestone Jun 19, 2020
@kliem
Copy link
Contributor Author

kliem commented Jun 19, 2020

Dependencies: #29898

@kliem
Copy link
Contributor Author

kliem commented Jun 20, 2020

Changed dependencies from #29898 to #29898, #29899

@kliem
Copy link
Contributor Author

kliem commented Jun 20, 2020

Last 10 new commits:

790dfbcfix trivial vertex facet graphs
d7cca49correct fix for 0-dimensional polyhedron
7c15f9eMerge branch 'public/29898' of git://trac.sagemath.org/sage into public/29908
bc5d247implement _test_is_combinatorially_isomorphic
e41d698fix universe from Hrep for cdd
e055bc7correctly detect the empty polyhedron
7eba64dtrivial inequality
067fb16also fix it for initialization from Hrep and Vrep
4609affMerge branch 'public/29899' of git://trac.sagemath.org/sage into public/29908
2ba5275remove numerically complicated test

@kliem
Copy link
Contributor Author

kliem commented Jun 20, 2020

Commit: 2ba5275

@kliem
Copy link
Contributor Author

kliem commented Jun 20, 2020

Branch: public/29908

@kliem
Copy link
Contributor Author

kliem commented Jun 20, 2020

Changed dependencies from #29898, #29899 to #29898, #29899, #29903

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 20, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

26890deunused import, unused variable

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 20, 2020

Changed commit from 2ba5275 to 26890de

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 22, 2020

Changed commit from 26890de to a6d49a1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 22, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

a6d49a1typo

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 19, 2020

Reviewer: Matthias Koeppe

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe mkoeppe changed the title Test method is_combinatorially_equivalent Test method is_combinatorially_isomorphic Jul 19, 2020
@kliem
Copy link
Contributor Author

kliem commented Jul 19, 2020

comment:7

Thank you.

@vbraun
Copy link
Member

vbraun commented Jul 25, 2020

Changed branch from public/29908 to a6d49a1

@vbraun vbraun closed this as completed in caa2305 Jul 25, 2020
@kliem kliem mentioned this issue Jan 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: geometry p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.2
Development

No branches or pull requests
3 participants
@vbraun @mkoeppe @kliem