Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tox.ini: debian-bullseye, -sid have Python3.8 instead of 3.7 #29851

Closed
cduston44 opened this issue Jun 12, 2020 · 11 comments
Closed

tox.ini: debian-bullseye, -sid have Python3.8 instead of 3.7 #29851

cduston44 opened this issue Jun 12, 2020 · 11 comments

Comments

@cduston44
Copy link

As per the wiki, running


build/bin/write-dockerfile.sh debian "@(standard|optional)" > Dockerfile

Generates a Dockerfile, but running the dockerfile fails because Debian (at least) comes with Python3.8, not 3.7. This can be fixed by changing the file build/pkgs/python3/distros/debian.txt, but I don't know if that will have unexpected consequences.

CC: @dimpase @kliem

Component: porting

Author: Matthias Koeppe

Branch/Commit: 1e7becc

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/29851

@cduston44 cduston44 added this to the sage-9.2 milestone Jun 12, 2020
@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 12, 2020

comment:1

Yes, this will have to be changed when we support Python 3.8 (#27754). At the moment, we only accept Python 3.7.x in configure; ticket #29033 adds Python 3.6.x support.

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 12, 2020

comment:2

Also, see the flag IGNORE_MISSING_SYSTEM_PACKAGES in tox.ini, which we use both for too old versions of the distribution that don't have all packages, and for too new versions of the distribution, such as ubuntu-focal.

@mkoeppe mkoeppe changed the title write-dockerfile.sh: Debian has Python3.8 instead of 3.7 tox.ini: debian-bullseye, -sid have Python3.8 instead of 3.7 Jun 12, 2020
@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 14, 2020

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 14, 2020

Commit: 1e7becc

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 14, 2020

New commits:

1e7becctox.ini [debian-buster, -sid]: IGNORE_MISSING_SYSTEM_PACKAGES=yes because of libpython3.7-dev

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 14, 2020

Author: Matthias Koeppe

@kliem
Copy link
Contributor

kliem commented Jun 18, 2020

Reviewer: Jonathan Kliem

@kliem
Copy link
Contributor

kliem commented Jun 18, 2020

comment:7

I already noticed the problem. So what this does it just make the workflow go through, even though it coulnd't install python3.7. It will later find out that no suitable python can be found and install python3.7 for sage.

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 19, 2020

comment:8

That's right. Best we can do before we get to Python 3.8 compatibility in #27754, which seems to have stalled

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 19, 2020

comment:10

Thanks!

@vbraun
Copy link
Member

vbraun commented Jul 8, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants