Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Macaulay2 interface broken by #28000 #29759

Closed
mwageringel opened this issue May 29, 2020 · 7 comments
Closed

fix Macaulay2 interface broken by #28000 #29759

mwageringel opened this issue May 29, 2020 · 7 comments
Labels
c: python3 p: major / 3 t: bug
Milestone
sage-9.2

Comments

@mwageringel
Copy link

This replaces one more six.string_types that was missed in #28000.

CC: @dimpase

Component: python3

Keywords: macaulay2

Author: Markus Wageringel

Branch/Commit: fd2eac0

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/29759
@mwageringel mwageringel added this to the sage-9.2 milestone May 29, 2020
@mwageringel
Copy link
Author

New commits:

fd2eac029759: replace string_types by str

@mwageringel
Copy link
Author

Commit: fd2eac0

@mwageringel
Copy link
Author

Branch: u/gh-mwageringel/29759

@fchapoton
Copy link
Contributor

comment:2

ok

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@mwageringel
Copy link
Author

comment:3

Thanks.

@vbraun
Copy link
Member

vbraun commented May 31, 2020

Changed branch from u/gh-mwageringel/29759 to fd2eac0

@vbraun vbraun closed this as completed in a3766ee May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: bug
Projects
None yet
Milestone
sage-9.2
Development

No branches or pull requests
3 participants
@vbraun @fchapoton @mwageringel