Ore polynomials

[xcaruso]

We implement general univariate Ore polynomials (allowing for derivations and twisted derivations)

Depends on #21264

CC: @tscrim @johanrosenkilde @Adurand8

Component: algebra

Author: Xavier Caruso

Branch/Commit: 1c7a67c

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/29629

[xcaruso]

Branch: u/caruso/ore_polynomials

[xcaruso]

Commit: 8984aa7

[xcaruso]

comment:2

This ticket is not ready for review yet: doctests need to be updated/completed.

---

New commits:

e3f2b25	rebase on top of ticket #21262
96dab84	add missing doctest in skew_polynomial_element
e8e9139	add a reference to my paper with Le Borgne
5897dfc	address Travis' comments
05c6bdf	make left_quo_rem and right_quo_rem cdef functions
99b4ee7	Merge branch 'u/caruso/skew_polynomial_finite_field_rebased' of git://trac.sagemath.org/sage into skew_polynomial_finite_field_rc1
eac641b	Making imports more local in matrices.
c5f5bd7	Merge branch 'u/tscrim/specific_imports_matrices-29561' of git://trac.sagemath.org/sage into skew_polynomial_finite_field_rc1
2ed055d	move imports
8984aa7	Working implementation of Ore polynomials

[xcaruso]

comment:3

Ticket is now ready for review.

[xcaruso]

Author: Xavier Caruso

[xcaruso]

Changed branch from u/caruso/ore_polynomials to u/caruso/ore_polynomials_rebased

[xcaruso]

Changed commit from 8984aa7 to d456551

[xcaruso]

Dependencies: #21264

[xcaruso]

comment:4

I add ticket #21264 in the dependencies because I built this one on top of it.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

f225cbc

fix pyflakes

[sagetrac-git]

Changed commit from d456551 to f225cbc

[xcaruso]

New commits:

f225cbc

fix pyflakes

[fchapoton]

comment:7

patchbots report one failing doctest

[sagetrac-git]

Changed commit from f225cbc to b35e1d0

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

b35e1d0

fix one doctest

[fchapoton]

comment:10

La branche est passée au rouge => needs work

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

131d78e

Merge branch 'develop' into t/29629/ore_polynomials_rebased

[sagetrac-git]

Changed commit from b35e1d0 to 131d78e

[tscrim]

comment:35

Okay, here are fixes for the documentation, including a number of tests that were not previously being run. I also fixed the not equals comparison for the skew polynomial injection maps. There were a number of other small trivial fixes (broken links, bad formatting, etc.) that I also fixed.

Documentation now builds and tests pass. So if my changes are good, then positive review.

---

New commits:

f111d30	Merge branch 'u/caruso/ore_polynomials_rebased' of git://trac.sagemath.org/sage into u/caruso/ore_polynomials_rebased
5d822f3	Fixing the doc and != for polynomial injection maps.

[xcaruso]

comment:36

Thanks!

[vbraun]

comment:37

Merge conflict

[xcaruso]

Changed branch from u/tscrim/ore_polynomials-29629 to u/caruso/ore_polynomials-29629

[xcaruso]

New commits:

1cc0ed8	Merge branch 'develop' into t/29629/ore_polynomials_rebased
200d7bd	update doctests

[xcaruso]

Changed commit from 5d822f3 to 200d7bd

[tscrim]

comment:40

Tests pass for me with the updated branch.

[tscrim]

comment:41

Docbuild is failing.

[tscrim]

Changed branch from u/caruso/ore_polynomials-29629 to u/tscrim/ore_polynomials-29629

[tscrim]

comment:42

Merged in my branch with your rebased branch to fix the docbuild issues. Since no conflicts, the doc builds, and you reviewed my changes, I am setting this back to a positive review.

---

New commits:

f111d30	Merge branch 'u/caruso/ore_polynomials_rebased' of git://trac.sagemath.org/sage into u/caruso/ore_polynomials_rebased
5d822f3	Fixing the doc and != for polynomial injection maps.
1c7a67c	Merge branch 'u/tscrim/ore_polynomials-29629' of git://trac.sagemath.org/sage into u/caruso/ore_polynomials-29629

[tscrim]

Changed commit from 200d7bd to 1c7a67c

[xcaruso]

comment:43

Thanks. And sorry for forgetting to pull your changes!

[vbraun]

Changed branch from u/tscrim/ore_polynomials-29629 to 1c7a67c