Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CombinatorialPolyhedron: Store incidence matrix on initialization #29566

Closed
kliem opened this issue Apr 24, 2020 · 10 comments
Closed

CombinatorialPolyhedron: Store incidence matrix on initialization #29566

kliem opened this issue Apr 24, 2020 · 10 comments
Labels
c: geometry p: minor / 4 t: enhancement
Milestone
sage-9.2

Comments

@kliem
Copy link
Contributor

kliem commented Apr 24, 2020

In case the combinatorial polyhedron is initialized from a matrix, we store the incidence matrix to avoid recomputation.

Note, that this is also the case when the combinatorial polyhedron is obtained e.g. from a polyhedron. In this case the incidence matrix is computed and then this is used to initialize the combinatorial polyhedron.

CC: @jplab @LaisRast

Component: geometry

Keywords: combinatorial polyhedron, incidence matrix

Author: Jonathan Kliem

Branch/Commit: 5d1a52e

Reviewer: Jean-Philippe Labbé

Issue created by migration from https://trac.sagemath.org/ticket/29566
@kliem kliem added this to the sage-9.2 milestone Apr 24, 2020
@kliem
Copy link
Contributor Author

kliem commented Apr 24, 2020

New commits:

5d1a52estore incidence matrix, if initialized from it

@kliem
Copy link
Contributor Author

kliem commented Apr 24, 2020

Branch: public/29566

@kliem
Copy link
Contributor Author

kliem commented Apr 24, 2020

Commit: 5d1a52e

@LaisRast
Copy link

comment:2

[deleted]

@kliem
Copy link
Contributor Author

kliem commented Apr 24, 2020

comment:3

Please move your comment to the correct ticket.

@LaisRast
Copy link

comment:5

Sorry.
I removed my comment and put it in the correct ticket.

@jplab
Copy link

jplab commented May 11, 2020

comment:6

Looks good to me.

@jplab
Copy link

jplab commented May 11, 2020

Reviewer: Jean-Philippe Labbé

@kliem
Copy link
Contributor Author

kliem commented May 11, 2020

comment:7

Thank you.

@vbraun
Copy link
Member

vbraun commented May 31, 2020

Changed branch from public/29566 to 5d1a52e

@vbraun vbraun closed this as completed in 06435c8 May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: geometry p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-9.2
Development

No branches or pull requests
4 participants
@vbraun @jplab @kliem @LaisRast