Don't use imports from rings.all in matrices

[tscrim]

This can cause import loops that are not naturally there when importing matrices at the top-level in skew polynomials. See, e.g., #21264

CC: @xcaruso

Component: refactoring

Author: Travis Scrimshaw

Branch/Commit: eac641b

Reviewer: Xavier Caruso

Issue created by migration from https://trac.sagemath.org/ticket/29561

[tscrim]

Commit: eac641b

[tscrim]

comment:1

Hopefully this will help untangle a bit of Sage's import hell too.

---

New commits:

eac641b

Making imports more local in matrices.

[tscrim]

Branch: u/tscrim/specific_imports_matrices-29561

[xcaruso]

comment:2

I know that they are not related to your changes but maybe you could also fix the pyflakes issues reported by the patchbot in this ticket:

git checkout patchbot/ticket_merged
src/sage/matrix/benchmark.py:145: local variable 'v' is assigned to but never used
src/sage/matrix/benchmark.py:184: local variable 'v' is assigned to but never used
src/sage/matrix/benchmark.py:223: local variable 'v' is assigned to but never used
src/sage/matrix/benchmark.py:261: local variable 'v' is assigned to but never used
src/sage/matrix/benchmark.py:301: local variable 'v' is assigned to but never used
src/sage/matrix/benchmark.py:343: local variable 'v' is assigned to but never used
src/sage/matrix/benchmark.py:387: local variable 'v' is assigned to but never used
src/sage/matrix/benchmark.py:452: local variable 'd' is assigned to but never used
src/sage/matrix/benchmark.py:492: local variable 'd' is assigned to but never used
src/sage/matrix/benchmark.py:536: local variable 'w' is assigned to but never used
src/sage/matrix/benchmark.py:615: local variable 'v' is assigned to but never used
src/sage/matrix/benchmark.py:654: local variable 'v' is assigned to but never used
src/sage/matrix/benchmark.py:692: local variable 'v' is assigned to but never used
src/sage/matrix/benchmark.py:738: local variable 'v' is assigned to but never used
src/sage/matrix/benchmark.py:778: local variable 'v' is assigned to but never used
src/sage/matrix/benchmark.py:814: local variable 'v' is assigned to but never used
src/sage/matrix/benchmark.py:851: local variable 'd' is assigned to but never used
src/sage/matrix/benchmark.py:913: local variable 'v' is assigned to but never used
src/sage/matrix/benchmark.py:952: local variable 'v' is assigned to but never used
src/sage/matrix/benchmark.py:994: local variable 'v' is assigned to but never used
src/sage/matrix/benchmark.py:1035: local variable 'd' is assigned to but never used
src/sage/matrix/benchmark.py:1069: local variable 'd' is assigned to but never used
src/sage/matrix/benchmark.py:1107: local variable 'w' is assigned to but never used
src/sage/matrix/benchmark.py:1160: local variable 'v' is assigned to but never used
src/sage/matrix/benchmark.py:1200: local variable 'v' is assigned to but never used

src/sage/matrix/matrix_integer_dense_hnf.py:17: 'sage.rings.rational_field.QQ' imported but unused

Apart from this, everything looks good to me.

[xcaruso]

Reviewer: Xavier Caruso

[mkoeppe]

comment:3

Does this ticket fix a bug and should go into 9.1?

[xcaruso]

comment:4

No, it does not really fix a bug. I think it can wait for 9.2.

[vbraun]

Changed branch from u/tscrim/specific_imports_matrices-29561 to eac641b