-
-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade NumPy to 1.18.5, scipy to 1.4.1, add pybind11 package #29425
Comments
comment:1
Can you try setting |
comment:2
This didn't make a difference |
comment:3
Upgrading numpy to 1.18.2 fixes it; but this will require a Cython upgrade too |
Commit: |
This comment has been minimized.
This comment has been minimized.
Author: Matthias Koeppe |
comment:7
Tests run at https://github.com/mkoeppe/sage/actions/runs/66127777 |
comment:8
Cython URL can be set to |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:10
Thanks! |
Reviewer: Isuru Fernando |
comment:12
Breaks py2 builds
|
comment:13
Setting milestone to 9.2, which is presumably the first py3-only release |
Commit: |
comment:45
Replying to @mkoeppe:
added the last commit to suppress the warning in the proper Pythonic way. The rest stays (mod rebase) |
comment:46
I'm getting various test failures |
comment:47
An upgrade ticket like this really needs to be run on the GitHub test infrastructure... |
comment:48
running GH Actions test here https://github.com/dimpase/sage/pull/9 |
comment:49
Replying to @mkoeppe:
Unfortunately there seem to be problems with runner setups, e.g. here
and a lot of
which seems to suggest that Do you know how to fix this? (there are other errors pointing at internal problems of runners) Can we easily extend setup to use our own runners? |
comment:51
In the meantime, numpy 1.18.5 has appeared |
comment:53
Tests (with #29766) run at https://github.com/mkoeppe/sage/pull/38/checks New commits:
|
This comment has been minimized.
This comment has been minimized.
comment:58
OK, running a new test without #29766 at https://github.com/mkoeppe/sage/pull/39/checks |
comment:59
Replying to @dimpase:
Actually, on
|
comment:60
Therefore, let's close this ticket and continue on #29766. |
Follow-up from the update of numpy to 1.16.6 (#29429):
We update
(latest as of 2020-06-05; both versions (and also the upcoming numpy 1.19) support python >= 3.6)
Depends on #29480
CC: @isuruf @dimpase @jdemeyer @embray @slel @vbraun
Component: porting
Author: Matthias Koeppe
Branch/Commit: u/mkoeppe/trac/local_conda_forge_macos_standard__build_error_with_numpy @
56a6fe1
Reviewer: Isuru Fernando, Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/29425
The text was updated successfully, but these errors were encountered: