Add GitHub CI workflow for cygwin #29295

mkoeppe · 2020-03-07T21:55:47Z

Using choco instead of apt-cyg because it is available out of the box on GitHub Actions, and can install cygwin unattended.

CC: @embray

Component: porting: Cygwin

Author: Matthias Koeppe

Branch/Commit: 85b3c3d

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/29295

The text was updated successfully, but these errors were encountered:

mkoeppe · 2020-03-08T02:52:55Z

Branch: u/mkoeppe/29106+ci

mkoeppe · 2020-03-08T02:55:48Z

Commit: 08279dc

mkoeppe · 2020-03-08T02:55:48Z

Author: Matthias Koeppe

mkoeppe · 2020-03-08T02:55:48Z

Last 10 new commits:

`d110ad6`	`use bash -l`
`a8f1400`	`chdir`
`877cc43`	`save pwd`
`9c8ea73`	`no autocrlf`
`6703eb9`	`save pwd`
`f6000b4`	`fixup, prepare log artifact`
`ceb422c`	`fixup`
`144da9e`	`use cygpath`
`b47e23a`	`debug`
`08279dc`	`do not fail fast`

mkoeppe · 2020-03-08T03:03:31Z

comment:3

This works pretty well already (https://github.com/mkoeppe/sage/runs/492908952?check_suite_focus=true)

Issues:

configure is run a second time at the beginning of make
a non-Cygwin python is in PATH and is picked up by sage-system-python. This should really be fixed by sage-system-python fixup #29090 ("configure forgets to check whether ANY Python is available on the system").

sagetrac-git · 2020-03-08T05:13:20Z

Changed commit from 08279dc to b212213

sagetrac-git · 2020-03-08T05:13:20Z

Branch pushed to git repo; I updated commit sha1. New commits:

`2603562`	`Reset PATH so that only cygwin binaries are used`
`f17762d`	`Simplify`
`b212213`	`build/pkgs/cygwin.txt: gcc -> gcc-core, gcc-c++`

mkoeppe · 2020-03-09T01:14:46Z

comment:5

Tests at https://github.com/mkoeppe/sage/actions/runs/51902280

sagetrac-git · 2020-03-09T01:17:00Z

Branch pushed to git repo; I updated commit sha1. New commits:

`d38b04b`	`git config --global core.symlinks true`

sagetrac-git · 2020-03-09T01:17:00Z

Changed commit from b212213 to d38b04b

dimpase · 2020-03-12T22:13:07Z

comment:7

I see here in the log some probably known to Erik issue, crypt module does not build for py3

building '_crypt' extension
gcc -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wno-unused -std=c99 -Wextra -Wno-unused-result -Wno-unused-parameter -Wno-missing-field-initializers -Wno-cast-function-type -Werror=implicit-function-declaration -I./Include -I/cygdrive/d/a/sage/sage/local/include -I. -I/cygdrive/d/a/sage/sage/local/var/tmp/sage/build/python3-3.7.3.p1/src/Include -I/cygdrive/d/a/sage/sage/local/var/tmp/sage/build/python3-3.7.3.p1/src -c /cygdrive/d/a/sage/sage/local/var/tmp/sage/build/python3-3.7.3.p1/src/Modules/_cryptmodule.c -o build/temp.cygwin-3.1.4-x86_64-3.7/cygdrive/d/a/sage/sage/local/var/tmp/sage/build/python3-3.7.3.p1/src/Modules/_cryptmodule.o
gcc -shared -Wl,--enable-auto-image-base -L/cygdrive/d/a/sage/sage/local/lib -Wl,-rpath,/cygdrive/d/a/sage/sage/local/lib -L. -L/cygdrive/d/a/sage/sage/local/lib -Wl,-rpath,/cygdrive/d/a/sage/sage/local/lib -L. -L/cygdrive/d/a/sage/sage/local/lib -Wl,-rpath,/cygdrive/d/a/sage/sage/local/lib build/temp.cygwin-3.1.4-x86_64-3.7/cygdrive/d/a/sage/sage/local/var/tmp/sage/build/python3-3.7.3.p1/src/Modules/_cryptmodule.o -L. -L/cygdrive/d/a/sage/sage/local/lib -L/usr/local/lib -L. -lpython3.7m -o build/lib.cygwin-3.1.4-x86_64-3.7/_crypt.dll
/usr/lib/gcc/x86_64-pc-cygwin/9.2.0/../../../../x86_64-pc-cygwin/bin/ld: build/temp.cygwin-3.1.4-x86_64-3.7/cygdrive/d/a/sage/sage/local/var/tmp/sage/build/python3-3.7.3.p1/src/Modules/_cryptmodule.o: in function `crypt_crypt_impl':
/cygdrive/d/a/sage/sage/local/var/tmp/sage/build/python3-3.7.3.p1/src/Modules/_cryptmodule.c:43: undefined reference to `crypt'
/cygdrive/d/a/sage/sage/local/var/tmp/sage/build/python3-3.7.3.p1/src/Modules/_cryptmodule.c:43:(.text+0x3a): relocation truncated to fit: R_X86_64_PC32 against undefined symbol `crypt'
collect2: error: ld returned 1 exit status

maybe it's just a forgotten Cygwin package:
https://cygwin.com/packages/summary/libcrypt0.html ?

mkoeppe · 2020-03-12T22:17:02Z

comment:8

See also #29012

sagetrac-git · 2020-03-12T22:37:22Z

Changed commit from d38b04b to 36f7b59

sagetrac-git · 2020-03-12T22:37:22Z

Branch pushed to git repo; I updated commit sha1. New commits:

`0f70082`	`build/pkgs/cygwin.txt: gcc -> gcc-core, gcc-c++`
`47e4395`	`build/pkgs/cygwin.txt: Add libcrypt0`
`d95e51a`	`src/doc/bootstrap: Generate cygwin.txt, cygwin-optional.txt`
`36f7b59`	`Merge branch 't/29106/ticket-29106' into t/29295/29106+ci`

sagetrac-git · 2020-03-13T00:59:35Z

Branch pushed to git repo; I updated commit sha1. New commits:

`14f2967`	`Actually use libcrypt-devel`
`68314dc`	`Merge branch 't/29106/ticket-29106' into t/29295/29106+ci`

sagetrac-git · 2020-03-13T00:59:35Z

Changed commit from 36f7b59 to 68314dc

sagetrac-git · 2020-03-13T01:00:38Z

Branch pushed to git repo; I updated commit sha1. New commits:

`b263ac3`	`Run ci-cygwin.yml also on pull request`

sagetrac-git · 2020-03-13T01:00:38Z

Changed commit from 68314dc to b263ac3

dimpase · 2020-03-13T08:30:34Z

comment:13

oh, right, it should have been https://cygwin.com/packages/summary/libcrypt-devel.html

mkoeppe · 2020-03-13T20:12:10Z

New commits:

`14f2967`	`Actually use libcrypt-devel`
`68314dc`	`Merge branch 't/29106/ticket-29106' into t/29295/29106+ci`
`b263ac3`	`Run ci-cygwin.yml also on pull request`

sagetrac-git · 2020-03-19T20:16:38Z

Changed commit from b263ac3 to 85b3c3d

sagetrac-git · 2020-03-19T20:16:38Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

`2034d61`	`save pwd`
`c4e44d1`	`fixup, prepare log artifact`
`193b699`	`fixup`
`b652a02`	`use cygpath`
`b8213bf`	`debug`
`e2f25de`	`do not fail fast`
`e56c8bd`	`Reset PATH so that only cygwin binaries are used`
`5fc4dd7`	`Simplify`
`488fb74`	`git config --global core.symlinks true`
`85b3c3d`	`Run ci-cygwin.yml also on pull request`

mkoeppe · 2020-03-19T20:16:59Z

Changed dependencies from #29106 to none

mkoeppe · 2020-03-19T20:17:09Z

comment:17

Rebased on 9.1.beta8

sagetrac-git · 2020-03-22T18:34:08Z

Changed commit from 85b3c3d to 8f2991d

sagetrac-git · 2020-03-22T18:34:08Z

Branch pushed to git repo; I updated commit sha1. New commits:

`d575cc1`	`ci-cygwin.yml: Run on pull requests only`
`8f2991d`	`.github/workflows/ci-cygwin.yml: Use sage-spkg -y -o`

sagetrac-git · 2020-03-22T18:39:53Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

sagetrac-git · 2020-03-22T18:39:53Z

Changed commit from 8f2991d to 85b3c3d

dimpase · 2020-03-24T16:46:13Z

comment:20

what is the point of having minimal here, as it takes too long?

mkoeppe · 2020-03-24T16:47:37Z

comment:21

Even if it times out, it provides valuable testing of the build process for the early packages.

mkoeppe · 2020-03-24T16:48:55Z

comment:22

But I'm working on the refinement of this workflow using several stages

dimpase · 2020-03-24T16:53:15Z

comment:23

ok

dimpase · 2020-03-24T16:53:15Z

Reviewer: Dima Pasechnik

vbraun · 2020-03-29T00:24:04Z

Changed branch from u/mkoeppe/29106+ci to 85b3c3d

mkoeppe added this to the sage-9.1 milestone Mar 7, 2020

mkoeppe added c: porting labels Mar 7, 2020

This comment has been minimized.

Sign in to view

mkoeppe added the s: needs review label Mar 12, 2020

mkoeppe added c: porting: cygwin and removed c: porting labels Mar 13, 2020

dimpase added s: positive review and removed s: needs review labels Mar 24, 2020

vbraun removed the s: positive review label Mar 29, 2020

vbraun closed this as completed in b82db0d Mar 29, 2020

Add GitHub CI workflow for cygwin #29295

Add GitHub CI workflow for cygwin #29295

Comments

mkoeppe commented Mar 7, 2020

mkoeppe commented Mar 8, 2020

mkoeppe commented Mar 8, 2020

mkoeppe commented Mar 8, 2020

mkoeppe commented Mar 8, 2020

This comment has been minimized.

mkoeppe commented Mar 8, 2020

sagetrac-git mannequin commented Mar 8, 2020

sagetrac-git mannequin commented Mar 8, 2020

mkoeppe commented Mar 9, 2020

sagetrac-git mannequin commented Mar 9, 2020

sagetrac-git mannequin commented Mar 9, 2020

dimpase commented Mar 12, 2020

mkoeppe commented Mar 12, 2020

sagetrac-git mannequin commented Mar 12, 2020

sagetrac-git mannequin commented Mar 12, 2020

sagetrac-git mannequin commented Mar 13, 2020

sagetrac-git mannequin commented Mar 13, 2020

sagetrac-git mannequin commented Mar 13, 2020

sagetrac-git mannequin commented Mar 13, 2020

dimpase commented Mar 13, 2020

mkoeppe commented Mar 13, 2020

sagetrac-git mannequin commented Mar 19, 2020

sagetrac-git mannequin commented Mar 19, 2020

mkoeppe commented Mar 19, 2020

mkoeppe commented Mar 19, 2020

sagetrac-git mannequin commented Mar 22, 2020

sagetrac-git mannequin commented Mar 22, 2020

sagetrac-git mannequin commented Mar 22, 2020

sagetrac-git mannequin commented Mar 22, 2020

dimpase commented Mar 24, 2020

mkoeppe commented Mar 24, 2020

mkoeppe commented Mar 24, 2020

dimpase commented Mar 24, 2020

dimpase commented Mar 24, 2020

vbraun commented Mar 29, 2020