-
-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up hypercube with both Vrep and Hrep (if backend supports it) #29198
Comments
Branch: public/29198 |
Commit: |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Changed branch from public/29198 to public/29198-reb |
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:6
Ok, that's the doctest from the bots. I also only got that one on my machine. Let's see what the bots say. It looks good apart from that. |
Reviewer: Jean-Philippe Labbé |
comment:8
Merge conflict |
Changed branch from public/29198-reb to public/29198-reb2 |
Changed reviewer from Jean-Philippe Labbé to Jean-Philippe Labbé, Sébastien Labbé |
comment:10
I confirm the timing improvements. I get all tests passed in |
Changed branch from public/29198-reb2 to |
Currently, the hypercube is set up with the vertices. This is slow, as the vertices grow exponentially with dimension:
With #28880 at hand, we can set up the hypercube with both Vrep and Hrep. If the backend supports it (as in
backend='field'
), then the double description does not need to be computed. If the backend does not support it (as inbackend='ppl'
), then the hypercube is set up from the inequalities, which is much faster:CC: @jplab @LaisRast
Component: geometry
Keywords: hypercube, polyhedron, double description
Author: Jonathan Kliem
Branch/Commit:
91ae9ba
Reviewer: Jean-Philippe Labbé, Sébastien Labbé
Issue created by migration from https://trac.sagemath.org/ticket/29198
The text was updated successfully, but these errors were encountered: