Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full-dimensional face of Polyhedron should have equations #29155

Closed
kliem opened this issue Feb 5, 2020 · 6 comments
Closed

Full-dimensional face of Polyhedron should have equations #29155

kliem opened this issue Feb 5, 2020 · 6 comments

Comments

@kliem
Copy link
Contributor

kliem commented Feb 5, 2020

Currently in a Polyhedron with lines, the full-dimensional face is initialized without equations:

A 2-dimensional face of a Polyhedron in ZZ^3 defined as the convex hull of 6 vertices
sage: P = polytopes.permutahedron(3)
sage: [f] = P.face_generator(2)
sage: f
A 2-dimensional face of a Polyhedron in ZZ^3 defined as the convex hull of 6 vertices
sage: f.ambient_Hrepresentation()
()

This is a bug from #28646 (probably introduced there). We fix this:

sage: P = polytopes.permutahedron(3)
sage: [f] = P.face_generator(2)
sage: f.ambient_Hrepresentation()
(An equation (1, 1, 1) x - 6 == 0,)

CC: @jplab @LaisRast

Component: geometry

Keywords: polytopes, universe face, equations

Author: Jonathan Kliem

Branch/Commit: d7f47ad

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/29155

@kliem kliem added this to the sage-9.1 milestone Feb 5, 2020
@kliem
Copy link
Contributor Author

kliem commented Feb 5, 2020

Branch: public/29155

@kliem
Copy link
Contributor Author

kliem commented Feb 5, 2020

Commit: d7f47ad

@kliem
Copy link
Contributor Author

kliem commented Feb 5, 2020

New commits:

d7f47adinitialize full-dimensional face with equations

@tscrim
Copy link
Collaborator

tscrim commented Feb 7, 2020

comment:2

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Feb 7, 2020

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Feb 11, 2020

Changed branch from public/29155 to d7f47ad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants