-
-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
is_inscribed
depends on order of vertices
#29125
Labels
Milestone
Comments
This comment has been minimized.
This comment has been minimized.
Branch: public/29125 |
New commits:
|
Commit: |
Reviewer: Jean-Philippe Labbé |
comment:3
Looks good to me. Thanks for fixing this error! Again, the pyflakes is fixed in another ticket. |
Changed branch from public/29125 to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the inscription test for polyhedra depends on the order of vertices:
The algorithm constructs a sphere around
dim + 1
vertices in general position. The circumcenter is computed up to sign. Then, one vertex is taken to determine, which sign to choose. However, up todim
vertices might lie on the intersection of both spheres.We fix this by checking distance from the circumcenter for all vertices of that simplex.
CC: @jplab @LaisRast
Component: geometry
Keywords: polytopes, is inscribed
Author: Jonathan Kliem
Branch/Commit:
3f9cc75
Reviewer: Jean-Philippe Labbé
Issue created by migration from https://trac.sagemath.org/ticket/29125
The text was updated successfully, but these errors were encountered: