Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CombinatorialPolyhedron: Expose is_bounded #29085

Closed
kliem opened this issue Jan 27, 2020 · 9 comments
Closed

CombinatorialPolyhedron: Expose is_bounded #29085

kliem opened this issue Jan 27, 2020 · 9 comments
Labels
c: geometry p: minor / 4 t: enhancement
Milestone
sage-9.1

Comments

@kliem
Copy link
Contributor

kliem commented Jan 27, 2020

CombinatorialPolyhedron has a method is_bounded, which is cython-only.

We expose this method under the name is_compact as in Polyhedron_base. Before it was hard to access this information.

CC: @jplab @LaisRast

Component: geometry

Keywords: combinatorial polyhedron, compactness

Author: Jonathan Kliem

Branch/Commit: 072708f

Reviewer: Laith Rastanawi

Issue created by migration from https://trac.sagemath.org/ticket/29085
@kliem kliem added this to the sage-9.1 milestone Jan 27, 2020
@kliem
Copy link
Contributor Author

kliem commented Jan 27, 2020

New commits:

19ccbe3expose is_bounded of CombinatorialPolyhedron

@kliem
Copy link
Contributor Author

kliem commented Jan 27, 2020

Branch: public/29085

@kliem
Copy link
Contributor Author

kliem commented Jan 27, 2020

Commit: 19ccbe3

@LaisRast
Copy link

comment:2

You misspelled the word polyhedron.
Otherwise everything looks good.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 28, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

072708ftypo

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 28, 2020

Changed commit from 19ccbe3 to 072708f

@kliem
Copy link
Contributor Author

kliem commented Jan 28, 2020

comment:4

Ok, fixed.

@LaisRast
Copy link

Reviewer: Laith Rastanawi

@vbraun
Copy link
Member

vbraun commented Jan 31, 2020

Changed branch from public/29085 to 072708f

@vbraun vbraun closed this as completed in 798a850 Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: geometry p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-9.1
Development

No branches or pull requests
3 participants
@vbraun @kliem @LaisRast