Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message for polar of non-full dimensional polyhedra #29074

Closed
kliem opened this issue Jan 24, 2020 · 5 comments
Closed

Better error message for polar of non-full dimensional polyhedra #29074

kliem opened this issue Jan 24, 2020 · 5 comments

Comments

@kliem
Copy link
Contributor

kliem commented Jan 24, 2020

In #28850 we added an error message when taking the polar of non-polar polytopes.

We also added a keyword in_affine_span, which restricts the polar construction to the affine span of the polytope.

As this is likely the output a user wants, we improve the error message.

We also mark a doctest a long time.

CC: @jplab @LaisRast

Component: geometry

Keywords: polytopes, polar

Author: Jonathan Kliem

Branch/Commit: 47a846e

Reviewer: Jean-Philippe Labbé

Issue created by migration from https://trac.sagemath.org/ticket/29074

@kliem kliem added this to the sage-9.1 milestone Jan 24, 2020
@kliem
Copy link
Contributor Author

kliem commented Jan 24, 2020

Branch: public/29074

@kliem
Copy link
Contributor Author

kliem commented Jan 24, 2020

New commits:

47a846eimproved error message for polar of non-fulldimensional polytopes

@kliem
Copy link
Contributor Author

kliem commented Jan 24, 2020

Commit: 47a846e

@jplab
Copy link

jplab commented Feb 4, 2020

comment:2

Looks good to me! The pyflakes is taken care of in #28880.

@vbraun
Copy link
Member

vbraun commented Feb 11, 2020

Changed branch from public/29074 to 47a846e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants