Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

little cleanup of imports and tweak again .lgtm.yml #29068

Closed
fchapoton opened this issue Jan 22, 2020 · 9 comments
Closed

little cleanup of imports and tweak again .lgtm.yml #29068

fchapoton opened this issue Jan 22, 2020 · 9 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-9.1

Comments

@fchapoton
Copy link
Contributor

  • removing unused imports as suggested by lgtm and pyflakes

  • mark some specific files as catalog-like in lgtm.yml

CC: @tscrim @jm58660 @vinklein

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: e2c8680

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/29068
@fchapoton fchapoton added this to the sage-9.1 milestone Jan 22, 2020
@fchapoton
Copy link
Contributor Author

New commits:

b5519eflittle cleanup of imports and tweak to lgtm.yml config file

@fchapoton
Copy link
Contributor Author

Commit: b5519ef

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/29068

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 23, 2020

Changed commit from b5519ef to e2c8680

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 23, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

e2c8680various import cleanup and lgtm.yml tweak

@fchapoton
Copy link
Contributor Author

comment:3

very tiny one, but the patchbot will not be able to check (unsafe changes)

@tscrim
Copy link
Collaborator

tscrim commented Jan 23, 2020

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jan 23, 2020

comment:4

LGTM.

@vbraun
Copy link
Member

vbraun commented Jan 25, 2020

Changed branch from u/chapoton/29068 to e2c8680

@vbraun vbraun closed this as completed in 96695b3 Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.1
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton