Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add script-type _spkg_check package that installs tox, mock, pytest etc. #28998

Closed
mkoeppe opened this issue Jan 13, 2020 · 13 comments
Closed

Add script-type _spkg_check package that installs tox, mock, pytest etc. #28998

mkoeppe opened this issue Jan 13, 2020 · 13 comments
Labels
c: build p: major / 3 t: enhancement

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 13, 2020

Following a suggestion by vbraun in #19680, this ticket adds a
_spkg_check package (type=script) that

  • installs the Python packagestox, mock, pytest via pip if SAGE_CHECK=true
  • does nothing otherwise.

The package _spkg_check can be added as a dependency of Python packages that use this standard testing infrastructure, for testing them if SAGE_CHECK=true.

The branch demonstrates this on the package pygments by adding an spkg-check.

If this approach is favored, probably the spkg nose, currently a dependency of cvxopt and networkx, could be removed.

CC: @vbraun @jdemeyer @kiwifb

Component: build

Branch/Commit: public/28998-check_dependencies_package @ 623cb21

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/28998
@mkoeppe mkoeppe added this to the sage-9.1 milestone Jan 13, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 13, 2020

Branch: public/28998-check_dependencies_package

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 13, 2020

comment:2

On this branch, handling of sage -c does not work yet.
Contributions welcome.

New commits:

623cb21Use script package 'check_dependencies' to install tox, pytest, etc.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 13, 2020

Commit: 623cb21

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe mkoeppe changed the title Add script-type check_dependencies package that installs tox, mock, pytest etc. Add script-type _spkg_check package that installs tox, mock, pytest etc. Feb 7, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 14, 2020

comment:5

pushing these forward to 9.2

@mkoeppe mkoeppe modified the milestones: sage-9.1, sage-9.2 Apr 14, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 6, 2020

comment:6

A simpler version, just for pytest, is in #29813, used in #29766 for networkx

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 20, 2020

comment:7

tox in #29909

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 4, 2020

comment:8

#30066: build/pkgs/mock: Downgrade from source=normal to pip, conditionalize dependencies

@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Aug 13, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 13, 2021

comment:10

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Feb 13, 2021
@mkoeppe mkoeppe removed this from the sage-9.4 milestone Jul 14, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 2, 2022

comment:12

Outdated, can close

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 2, 2022

Changed author from Matthias Koeppe to none

@slel
Copy link
Member

slel commented Jan 3, 2022

Reviewer: Matthias Koeppe

@slel slel closed this as completed Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build p: major / 3 t: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@slel @mkoeppe