Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

little tweak to our lgtm config file #28995

Closed
fchapoton opened this issue Jan 12, 2020 · 15 comments
Closed

little tweak to our lgtm config file #28995

fchapoton opened this issue Jan 12, 2020 · 15 comments

Comments

@fchapoton
Copy link
Contributor

so that files named all.py and catalog.py are ignored.

see

https://help.semmle.com/lgtm-enterprise/user/help/lgtm.yml-configuration-file.html#path_classifiers

CC: @embray @kiwifb @isuruf @tscrim

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: 967c510

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/28995

@fchapoton fchapoton added this to the sage-9.1 milestone Jan 12, 2020
@fchapoton
Copy link
Contributor Author

New commits:

f75c866little tweak to lgtm yaml config file

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/28995

@fchapoton
Copy link
Contributor Author

Commit: f75c866

@fchapoton

This comment has been minimized.

@tscrim
Copy link
Collaborator

tscrim commented Jan 12, 2020

comment:4

How about excluding all files with catalog in the name?

@fchapoton
Copy link
Contributor Author

comment:5

good idea, let me do that

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 12, 2020

Changed commit from f75c866 to 8c46cc1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 12, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

8c46cc1still better lgtm.yml

@tscrim
Copy link
Collaborator

tscrim commented Jan 12, 2020

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jan 12, 2020

comment:7

Are there any catalog files of the form foo_catalog.py? If not, then positive review.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 12, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

967c510little tweak to lgtm yaml config file

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 12, 2020

Changed commit from 8c46cc1 to 967c510

@fchapoton
Copy link
Contributor Author

comment:9

indeed, there are some..

@tscrim
Copy link
Collaborator

tscrim commented Jan 12, 2020

comment:10

Thanks. LGTM.

@vbraun
Copy link
Member

vbraun commented Jan 20, 2020

Changed branch from u/chapoton/28995 to 967c510

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants