Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize CombinatorialPolyhedron from incidence matrix of cone or lattice polytope #28960

Closed
kliem opened this issue Jan 6, 2020 · 10 comments
Closed

Initialize CombinatorialPolyhedron from incidence matrix of cone or lattice polytope #28960

kliem opened this issue Jan 6, 2020 · 10 comments
Labels
c: geometry p: major / 3 t: enhancement
Milestone
sage-9.1

Comments

@kliem
Copy link
Contributor

kliem commented Jan 6, 2020

#28743 and #28766 implemented the incidence matrix for lattice polytopes and cones.

We use the incidence matrix to

  • accept a cone as input of CombinatorialPolyhedron,
  • process a lattice polytope as input more easily.

In both cases the CombinatorialPolyhedron can be obtained without previously calculating the face lattice (avoiding the method facets).

CC: @jplab @LaisRast

Component: geometry

Keywords: combinatorial polyhedron, cone, lattice polytope

Author: Jonathan Kliem

Branch/Commit: d513adc

Reviewer: Laith Rastanawi

Issue created by migration from https://trac.sagemath.org/ticket/28960
@kliem kliem added this to the sage-9.1 milestone Jan 6, 2020
@kliem
Copy link
Contributor Author

kliem commented Jan 6, 2020

Branch: public/28960

@kliem
Copy link
Contributor Author

kliem commented Jan 6, 2020

New commits:

00a3bf5initialize combinatorial polyhedron from cone and lattice polytope

@kliem
Copy link
Contributor Author

kliem commented Jan 6, 2020

Commit: 00a3bf5

@kliem
Copy link
Contributor Author

kliem commented Mar 19, 2020

comment:2

Apply failed.

@kliem
Copy link
Contributor Author

kliem commented Mar 19, 2020

Changed commit from 00a3bf5 to d513adc

@kliem
Copy link
Contributor Author

kliem commented Mar 19, 2020

Changed branch from public/28960 to public/28960-reb

@kliem
Copy link
Contributor Author

kliem commented Mar 19, 2020

New commits:

d513adcinitialize combinatorial polyhedron from cone and lattice polytope

@LaisRast
Copy link

LaisRast commented Apr 3, 2020

Reviewer: Laith Rastanawi

@LaisRast
Copy link

LaisRast commented Apr 3, 2020

comment:4

It looks good to me!

@vbraun
Copy link
Member

vbraun commented Apr 9, 2020

Changed branch from public/28960-reb to d513adc

@vbraun vbraun closed this as completed in 2e00b63 Apr 9, 2020
@kliem kliem mentioned this issue Apr 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: geometry p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.1
Development

No branches or pull requests
3 participants
@vbraun @kliem @LaisRast