Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing edges when visualizing Polyhedra with threejs #28662

Closed
jplab opened this issue Oct 28, 2019 · 9 comments
Closed

Missing edges when visualizing Polyhedra with threejs #28662

jplab opened this issue Oct 28, 2019 · 9 comments

Comments

@jplab
Copy link

jplab commented Oct 28, 2019

When visualizing polyhedra with threejs, the edges are missing:

sage: p = polytopes.icosahedron()
sage: p.plot()
Launched html viewer for Graphics3d Object 

but

sage: icosahedron()

seems to have the edges.

CC: @dimpase @paulmasson @egourgoulhon

Component: graphics

Keywords: threejs, polyhedron, polytope

Author: Paul Masson

Branch/Commit: ca23e0f

Reviewer: Eric Gourgoulhon, Jean-Philippe Labbé

Issue created by migration from https://trac.sagemath.org/ticket/28662

@jplab jplab added this to the sage-9.0 milestone Oct 28, 2019
@paulmasson
Copy link
Mannequin

paulmasson mannequin commented Oct 28, 2019

Branch: u/paulmasson/28662

@paulmasson
Copy link
Mannequin

paulmasson mannequin commented Oct 28, 2019

Commit: ca23e0f

@paulmasson
Copy link
Mannequin

paulmasson mannequin commented Oct 28, 2019

comment:2

During the cleanup while adding mesh plots I overlooked this index that needed to be changed. Oops!


New commits:

ca23e0fFix addLine()

@paulmasson
Copy link
Mannequin

paulmasson mannequin commented Oct 28, 2019

Author: Paul Masson

@paulmasson paulmasson mannequin added the s: needs review label Oct 28, 2019
@egourgoulhon
Copy link
Member

comment:3

Thanks for the fix! LGTM.

@egourgoulhon
Copy link
Member

Reviewer: Eric Gourgoulhon

@jplab
Copy link
Author

jplab commented Oct 29, 2019

comment:4

Replying to @egourgoulhon:

Thanks for the fix! LGTM.

+1

Thanks for the quick fix!

@egourgoulhon
Copy link
Member

Changed reviewer from Eric Gourgoulhon to Eric Gourgoulhon, Jean-Philippe Labbé

@vbraun
Copy link
Member

vbraun commented Oct 29, 2019

Changed branch from u/paulmasson/28662 to ca23e0f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants