Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyhedron: Preserve backend for barycentric subdivision #28430

Closed
kliem opened this issue Aug 30, 2019 · 8 comments
Closed

Polyhedron: Preserve backend for barycentric subdivision #28430

kliem opened this issue Aug 30, 2019 · 8 comments

Comments

@kliem
Copy link
Contributor

kliem commented Aug 30, 2019

This is a follow up of #27926. barycentric_subdivision was forgotten there.

Currently we have

sage: polytopes.simplex(backend='field').barycentric_subdivision().backend()
'ppl'

The backend should not be changed with this construction, so the desired output in this case is 'field'.

CC: @jplab @videlec

Component: geometry

Keywords: polyhedron, polytopes, barycentric subdivision, backend

Author: Jonathan Kliem

Branch/Commit: ae7d717

Reviewer: Jean-Philippe Labbé

Issue created by migration from https://trac.sagemath.org/ticket/28430

@kliem kliem added this to the sage-8.9 milestone Aug 30, 2019
@kliem
Copy link
Contributor Author

kliem commented Aug 30, 2019

Branch: public/28430

@kliem
Copy link
Contributor Author

kliem commented Aug 30, 2019

New commits:

ae7d717preserve backend for barycentric subdivision

@kliem
Copy link
Contributor Author

kliem commented Aug 30, 2019

Commit: ae7d717

@jplab
Copy link

jplab commented Aug 30, 2019

comment:2

Wow! Fast at fixing it! Great!

@tscrim
Copy link
Collaborator

tscrim commented Sep 3, 2019

comment:3

Is that a positive review JP?

@jplab
Copy link

jplab commented Sep 3, 2019

Reviewer: Jean-Philippe Labbé

@jplab
Copy link

jplab commented Sep 3, 2019

comment:4

At the moment that I wrote the lines, I was thinking about a potential improvement of the method, but it turns out it is a bit more involved, so I'd say yes, it is a positive review.

@vbraun
Copy link
Member

vbraun commented Sep 5, 2019

Changed branch from public/28430 to ae7d717

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants