Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py3: polyhedron folder with optional packages #28235

Closed
jplab opened this issue Jul 23, 2019 · 15 comments
Closed

py3: polyhedron folder with optional packages #28235

jplab opened this issue Jul 23, 2019 · 15 comments

Comments

@jplab
Copy link

jplab commented Jul 23, 2019

There are 7 failing doctests in base.py using optional packages (latte_int and lrslib):

----------------------------------------------------------------------
sage -t src/sage/geometry/polyhedron/base.py  # 7 doctests failed
sage -t src/sage/geometry/polyhedron/base_ZZ.py  # 1 doctest failed
----------------------------------------------------------------------

This tickets fixes them. The remaining packages are 'polymake' and 'polytopes_db_4d', which are experimental or not yet known status (see #26029).

CC: @jplab @mkoeppe @videlec @fchapoton

Component: python3

Keywords: polyhedron, days100

Author: Jean-Philippe Labbé

Branch/Commit: 846069d

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/28235

@jplab jplab added this to the sage-8.9 milestone Jul 23, 2019
@jplab
Copy link
Author

jplab commented Jul 23, 2019

Branch: public/28235

@jplab
Copy link
Author

jplab commented Jul 23, 2019

New commits:

d3dc7aafix py3 in base.py with optional packages

@jplab

This comment has been minimized.

@jplab
Copy link
Author

jplab commented Jul 23, 2019

Commit: d3dc7aa

@jplab

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 23, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

c69d74fmoved the import statement

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 23, 2019

Changed commit from d3dc7aa to c69d74f

@jplab
Copy link
Author

jplab commented Jul 23, 2019

comment:4

... received the green light from chapoton.

@jplab
Copy link
Author

jplab commented Jul 23, 2019

Reviewer: Frédéric Chapoton

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 24, 2019

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

e5ecbcfpyflakes

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 24, 2019

Changed commit from c69d74f to e5ecbcf

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 24, 2019

Changed commit from e5ecbcf to 846069d

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 24, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

846069dpyflakes-bis

@fchapoton
Copy link
Contributor

comment:7

allons-y

@vbraun
Copy link
Member

vbraun commented Jul 29, 2019

Changed branch from public/28235 to 846069d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants