Implement facets method for Polyhedron

[jplab]

It is often practical to get directly the facets of a polyhedron object without having to compute or to know the dimension of the object.

This ticket implements the following shortcut:

sage: c = polytopes.hypercube(4)
sage: dim = c.dimension()
sage: c.faces(dim-1)
(A 3-dimensional face of a Polyhedron in ZZ^4 defined as the convex hull of 8 vertices,
 A 3-dimensional face of a Polyhedron in ZZ^4 defined as the convex hull of 8 vertices,
 A 3-dimensional face of a Polyhedron in ZZ^4 defined as the convex hull of 8 vertices,
 A 3-dimensional face of a Polyhedron in ZZ^4 defined as the convex hull of 8 vertices,
 A 3-dimensional face of a Polyhedron in ZZ^4 defined as the convex hull of 8 vertices,
 A 3-dimensional face of a Polyhedron in ZZ^4 defined as the convex hull of 8 vertices,
 A 3-dimensional face of a Polyhedron in ZZ^4 defined as the convex hull of 8 vertices,
 A 3-dimensional face of a Polyhedron in ZZ^4 defined as the convex hull of 8 vertices)

Now becomes:

sage: c = polytopes.hypercube(4)
sage: c.facets()
(A 3-dimensional face of a Polyhedron in ZZ^4 defined as the convex hull of 8 vertices,
 A 3-dimensional face of a Polyhedron in ZZ^4 defined as the convex hull of 8 vertices,
 A 3-dimensional face of a Polyhedron in ZZ^4 defined as the convex hull of 8 vertices,
 A 3-dimensional face of a Polyhedron in ZZ^4 defined as the convex hull of 8 vertices,
 A 3-dimensional face of a Polyhedron in ZZ^4 defined as the convex hull of 8 vertices,
 A 3-dimensional face of a Polyhedron in ZZ^4 defined as the convex hull of 8 vertices,
 A 3-dimensional face of a Polyhedron in ZZ^4 defined as the convex hull of 8 vertices,
 A 3-dimensional face of a Polyhedron in ZZ^4 defined as the convex hull of 8 vertices)

CC: @jplab @LaisRast @kliem @sophiasage

Component: geometry

Keywords: polytopes, facets, days100

Author: Sophia Elia

Branch/Commit: 743c4c7

Reviewer: Jean-Philippe Labbé, Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/27974

[embray]

comment:1

As the Sage-8.8 release milestone is pending, we should delete the sage-8.8 milestone for tickets that are not actively being worked on or that still require significant work to move forward. If you feel that this ticket should be included in the next Sage release at the soonest please set its milestone to the next release milestone (sage-8.9).

[sophiasage]

Commit: 8dc7dd5

[sophiasage]

New commits:

8dc7dd5

implement facets

[sophiasage]

Author: Sophia Elia

[sophiasage]

Branch: public/27974

[sophiasage]

Changed keywords from polytopes, facets to polytopes, facets, days100

[fchapoton]

comment:4

Suggestion: add cross-references, in the new method:

        .. SEEALSO:: :meth:`faces`

and the same in the other direction

[jplab]

comment:5

Suggestion: in the files base.py, face.py, and library.py, perhaps it would be nice to change the tests involving faces(a_number_here) where the intented thing is really .facets.

This way, the function is advertized in the documentation of functions, and also well-tested.

There are sufficient tests with faces that are not facets not to have this a regression. Further, it still uses faces anyways. So no loss in strength of testing...

One comment about the bot result: The pyflake line is taken care of in #27993.

[sagetrac-git]

Changed commit from 8dc7dd5 to 76a87d7

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

76a87d7

added cross-references, changed faces examples to facets where appropriate

[jplab]

comment:7

LGTM, pyflakes errors are taken care of in #27993.

[jplab]

Reviewer: Jean-Philippe Labbé

[vbraun]

comment:8

Merge conflict

[jplab]

comment:9

Please remove the insertion of spaces in the banner.

The conflict is probably from the library somewhere...

[fchapoton]

comment:10

Looks good and the patchbot is green.

One detail needs to be fixed :

There is a seealso in facets referring to facets. It should refer to faces instead.

Once done, you can set to positive review on my behalf.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

e03f2ee

fixed seealso typo

[sagetrac-git]

Changed commit from 76a87d7 to e03f2ee

[vbraun]

comment:13

Merge conflict, please merge in the next beta

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

3362dc1	implement facets
1ab0c3f	rebased facets on sage8.9.beta9
e3621b8	fixed seealso typo

[sagetrac-git]

Changed commit from e03f2ee to e3621b8

[sagetrac-git]

Changed commit from e3621b8 to e3177be

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

e3177be

banner fix

[sagetrac-git]

Changed commit from e3177be to f72960d

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

f72960d

banner fix again

[sagetrac-git]

Changed commit from f72960d to 743c4c7

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

743c4c7

added facets method to quickref

[fchapoton]

comment:20

ok, good to go

[fchapoton]

Changed reviewer from Jean-Philippe Labbé to Jean-Philippe Labbé, Frédéric chapoton

[jplab]

Changed reviewer from Jean-Philippe Labbé, Frédéric chapoton to Jean-Philippe Labbé, Frédéric Chapoton

[vbraun]

Changed branch from public/27974 to 743c4c7