Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove some deprecated stuff in symbolics #27947

Closed
fchapoton opened this issue Jun 7, 2019 · 10 comments
Closed

remove some deprecated stuff in symbolics #27947

fchapoton opened this issue Jun 7, 2019 · 10 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-8.9

Comments

@fchapoton
Copy link
Contributor

after #12384, #11912 and #17438

CC: @tscrim @rwst

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: b815238

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/27947
@fchapoton fchapoton added this to the sage-8.8 milestone Jun 7, 2019
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/27947

@fchapoton
Copy link
Contributor Author

Commit: de950f9

@fchapoton
Copy link
Contributor Author

New commits:

de950f9remove long deprecated stuff in symbolics

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 7, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

b815238remove the deprecated method calls

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 7, 2019

Changed commit from de950f9 to b815238

@fchapoton
Copy link
Contributor Author

comment:3

green bot, please review

@tscrim
Copy link
Collaborator

tscrim commented Jun 8, 2019

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jun 8, 2019

comment:4

LGTM.

@vbraun
Copy link
Member

vbraun commented Jun 27, 2019

Changed branch from u/chapoton/27947 to b815238

@vbraun vbraun closed this as completed in 2272f0d Jun 27, 2019
@embray
Copy link
Contributor

embray commented Jul 3, 2019

comment:6

Not in Sage 8.8. Let's please to try keep tickets' milestones related to the release in which we actually intend to include them, and in particular the release in which they were actually included, especially when closing tickets.

@embray embray modified the milestones: sage-8.8, sage-8.9 Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-8.9
Development

No branches or pull requests
4 participants
@embray @vbraun @tscrim @fchapoton