Mark some tests involving long using the # py2 tag

[jhpalmieri]

Since long is not available in Python 3, we should mark tests involving it as for Python 2 only. This is part of #27696.

Depends on #27826

Component: python3

Author: John Palmieri

Branch/Commit: u/jhpalmieri/long-py2 @ feac66d

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/27829

[jhpalmieri]

Branch: u/jhpalmieri/long-py2

[jhpalmieri]

Commit: 422e759

[jhpalmieri]

New commits:

422e759

trac 27829: add "# py2" to some tests involving "long(...)"

[jhpalmieri]

comment:3

There are a few cases I didn't know what to do with. In the following, I don't think long(...) adds much, so I think it's okay to make these changes. I have not yet done so. Opinions?

diff --git a/src/sage/rings/complex_double.pyx b/src/sage/rings/complex_double.pyx
index ec43d0e199..21c9818780 100644
--- a/src/sage/rings/complex_double.pyx
+++ b/src/sage/rings/complex_double.pyx
@@ -398,7 +398,7 @@ cdef class ComplexDoubleField_class(sage.rings.ring.Field):
 
             sage: CDF(1) + RR(1)
             2.0
-            sage: CDF.0 - CC(1) - long(1) - RR(1) - QQbar(1)
+            sage: CDF.0 - CC(1) - ZZ(1) - RR(1) - QQbar(1)
             -4.0 + 1.0*I
             sage: CDF.has_coerce_map_from(ComplexField(20))
             False
diff --git a/src/sage/modules/free_module_element.pyx b/src/sage/modules/free_module_element.pyx
index 03d4d57a28..e069377806 100644
--- a/src/sage/modules/free_module_element.pyx
+++ b/src/sage/modules/free_module_element.pyx
@@ -382,7 +382,7 @@ def vector(arg0, arg1=None, arg2=None, sparse=None):
         (0, 1, 2, 3, 4, 5, 6, 7, 8, 9)
         sage: v[3].parent()
         Integer Ring
-        sage: v = vector([float(23.4), int(2), complex(2+7*I), long(1)]); v
+        sage: v = vector([float(23.4), int(2), complex(2+7*I), 1]); v
         (23.4, 2.0, 2.0 + 7.0*I, 1.0)
         sage: v[1].parent()
         Complex Double Field
diff --git a/src/sage/rings/real_mpfr.pyx b/src/sage/rings/real_mpfr.pyx
index ae74119795..a579b5a575 100644
--- a/src/sage/rings/real_mpfr.pyx
+++ b/src/sage/rings/real_mpfr.pyx
@@ -719,7 +719,7 @@ cdef class RealField_class(sage.rings.ring.Field):
 
         TESTS::
 
-            sage: 1.0 - ZZ(1) - int(1) - long(1) - QQ(1) - RealField(100)(1) - AA(1) - RLF(1)
+            sage: 1.0 - ZZ(1) - int(1) - 1 - QQ(1) - RealField(100)(1) - AA(1) - RLF(1)
             -6.00000000000000
             sage: R = RR['x']   # Hold reference to avoid garbage collection, see Trac #24709
             sage: R.get_action(ZZ)

[sagetrac-git]

Changed commit from 422e759 to feac66d

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

feac66d

trac 27829: add "# py2" to some tests involving "long(...)"

[jdemeyer]

comment:5

I don't think that # optional - fricas py2 works the way you think it does: you need # py2 not # optional - py2.

[jdemeyer]

comment:6

For large numbers (which don't fit in a Python 2 int anyway), you can replace long() by int(), for example

a = long(-901824309821093821093812093810928309183091832091)

becomes

a = int(-901824309821093821093812093810928309183091832091)

(unless the goal of the doctest is precisely testing __long__ which is not the case here).

[jhpalmieri]

comment:7

Replying to @jdemeyer:

I don't think that # optional - fricas py2 works the way you think it does: you need # py2 not # optional - py2.

It works exactly the way I think it does, I just made a mistake.

[jhpalmieri]

comment:8

Any changes in #27826 are likely to affect this ticket, so marking as "needs work" until #27826 has stabilized.

[embray]

comment:9

Tickets still needing working or clarification should be moved to the next release milestone at the soonest (please feel free to revert if you think the ticket is close to being resolved).

[vbraun]

comment:10

Surely these all have been fixed by now and this ticket can be closed?

[jhpalmieri]

comment:11

No, because we still have

    if six.PY2:
        extra_globals = {}
    else:
        extra_globals = {'long': int}

in doctest/forker.py, so tests involving long can still pass with Python 3.

#27826 should be resolved first, and then this ticket afterwards.

[jhpalmieri]

Dependencies: #27826

[embray]

comment:12

Ticket retargeted after milestone closed

[mkoeppe]

comment:13

Moving tickets to milestone sage-9.2 based on a review of last modification date, branch status, and severity.

[mkoeppe]

comment:14

Replying to @jhpalmieri:

#27826 should be resolved first, and then this ticket afterwards.

This has happened

[jhpalmieri]

comment:15

I think we can close this as invalid now that we don't build Python 2 anymore.

[mkoeppe]

Reviewer: Matthias Koeppe