fflas_ffpack is not tested, tests fail

[timokau]

While trying to port the nix build (and its dependencies) to darwin, @jbaum98 discovered that the fflas-ffpack tests are failing on darwin when using openblas. They don't fail on linux using openblas and they don't fail on darwin using another blas.

Trying to figure out if that is a nix issue or a fflas-ffpack / openblas issue, I compared our build with the sage spkg. I noticed that sage is not even running the fflas_ffpack tests. So maybe some issues with darwin have gone unnoticed.

I even get one test failure on linux:

FAIL: test-fgemm-check
======================

Checking ............................Modular<double> mod 67 ... PASSED with seed = 1535225205942725
Checking ........................Modular<double> mod 351293 ... PASSED with seed = 1535225205942726
Checking .........................Modular<double> mod 17659 ... PASSED with seed = 1535225205942727
Checking ....................ModularBalanced<double> mod 67 ... PASSED with seed = 1535225205942725
Checking ................ModularBalanced<double> mod 351293 ... PASSED with seed = 1535225205942726
Checking .................ModularBalanced<double> mod 17659 ... PASSED with seed = 1535225205942727
Checking .............................Modular<float> mod 13 ... FAILED
FAILED with seed = 1535225205942725
FAIL test-fgemm-check (exit status: 1)

Upstream issue: linbox-team/fflas-ffpack#146

Upstream: Fixed upstream, in a later stable release.

CC: @videlec @ClementPernet @dimpase @antonio-rojas @mkoeppe

Component: packages: standard

Keywords: darwin

Author: Timo Kaufmann

Branch/Commit: 3ff111f

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/26130

[timokau]

New commits:

a1b9e6f

Enable fflas_ffpack tests

[timokau]

Author: Timo Kaufmann

[timokau]

Upstream: Reported upstream. No feedback yet.

[timokau]

Commit: a1b9e6f

[timokau]

Changed keywords from none to darwin

[timokau]

Branch: public/26130

[sagetrac-git]

Changed commit from a1b9e6f to 3ff111f

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

3ff111f

Enable fflas_ffpack tests

[timokau]

comment:3

Setting to needs_review since someone with acess to a darwin machine needs to test this.

[vinklein]

comment:5

On Darwin i get a fail with openblas too

$ sage -f -c fflas_ffpack
...
[fflas_ffpack-2.3.2] PASS: test-ftrmm
[fflas_ffpack-2.3.2] FAIL: test-fgemm-check
[fflas_ffpack-2.3.2] PASS: test-permutations
...

It look like it's a fflas-ffpack / openblas issue.

# file test-fgemm-check.log
Checking ..........................Modular<double> mod 1693 ... PASSED with seed = 1541770760090127
Checking .........................Modular<double> mod 12421 ... PASSED with seed = 1541770760090128
Checking ...........................Modular<double> mod 139 ... PASSED with seed = 1541770760090129
Checking ..................ModularBalanced<double> mod 1693 ... PASSED with seed = 1541770760090127
Checking .................ModularBalanced<double> mod 12421 ... PASSED with seed = 1541770760090128
Checking ...................ModularBalanced<double> mod 139 ... PASSED with seed = 1541770760090129
Checking ...........................Modular<float> mod 1693 ... PASSED with seed = 1541770760090127
Checking .............................Modular<float> mod 47 ... FAILED
FAILED with seed = 1541770760090128
FAIL test-fgemm-check (exit status: 1)

[timokau]

comment:6

It'd be great if you can help upstream find the cause of it in linbox-team/fflas-ffpack#173 :)

@jbaum98 had more test failures there, but this is one of them and he isn't responding. Maybe they have a common cause.

[vinklein]

Changed upstream from Reported upstream. No feedback yet. to Fixed upstream, in a later stable release.

[embray]

comment:9

Moving tickets from the Sage 8.8 milestone that have been actively worked on in the last six months to the next release milestone (optimistically).

[embray]

comment:10

Ticket retargeted after milestone closed

[mkoeppe]

comment:12

Tested at https://github.com/mkoeppe/sage/actions/runs/32812271 on top of 9.1.beta2

[mkoeppe]

Reviewer: Matthias Koeppe

[vbraun]

Changed branch from public/26130 to 3ff111f