Bounding box bug in Polyhedron plots

[jplab]

As reported on sage-devel here [#point1 (1)] and there [#point2 (2)], when creating a polyhedron far from the origin, the bounding box for the plot of the polyhedron includes the origin by default and it makes the polyhedron appear small. This appears to be a bug in the polyhedron.plot currently at line 1248 when an empty Graphics3d object is created.

[=#point1 (1)] https://groups.google.com/forum/#!topic/sage-devel/6v-d6PM29YM

[=#point2 (2)] https://groups.google.com/forum/#!msg/cocalc/YQQHboBCwPw/d8-NlOS8BwAJ

CC: @mo271

Component: geometry

Keywords: polyhedron, days88

Author: Moritz Firsching

Branch/Commit: 3f02385

Reviewer: Jean-Philippe Labbé, Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/23555

[mforets]

comment:1

(for reference) difference between 2d and 3d plots:

sage: import itertools
sage: Polyhedron(vertices=itertools.product([100, 101], repeat=2)).plot() # OK, centered around the polyhedron
sage: Polyhedron(vertices=itertools.product([100, 101], repeat=3)).plot() # not centered, displays origin

[mo271]

Branch: u/moritz/23555

[sagetrac-git]

Commit: 6fc28c0

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

6fc28c0

added doctest

[mo271]

Author: Moritz Firsching

[mo271]

comment:4

This fixes it, I guess.
Check out the doctest. If unpatched, the output should be

((0.0, 0.0, 0.0), (101.0, 101.0, 101.0))

[mo271]

Changed keywords from none to polyhedron

[jplab]

Reviewer: Jean-Philippe Labbé

[jplab]

Changed keywords from polyhedron to polyhedron, days88

[jplab]

comment:5

Looks good to me.

[vbraun]

comment:6

Documentation doesn't build

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

d9ba49c	don't invoke Graphics3d() for empty plot
a24a06e	added doctest
17ad101	prevent adding of 'None'

[sagetrac-git]

Changed commit from 6fc28c0 to 17ad101

[mo271]

comment:8

I hope that fixes the issue..

[fchapoton]

comment:9

typo: "The origin is no included" >>> "The origin is not included"

[sagetrac-git]

Changed commit from 17ad101 to 3f02385

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

5856470	don't invoke Graphics3d() for empty plot
244aff0	added doctest
856df77	prevent adding of 'None'
3f02385	typo

[fchapoton]

Changed reviewer from Jean-Philippe Labbé to Jean-Philippe Labbé, Frédéric Chapoton

[fchapoton]

comment:11

ok

[vbraun]

Changed branch from u/moritz/23555 to 3f02385