Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: use six.integer_types (step 2/2) #22879

Closed
fchapoton opened this issue Apr 26, 2017 · 11 comments
Closed

py3: use six.integer_types (step 2/2) #22879

fchapoton opened this issue Apr 26, 2017 · 11 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-8.0

Comments

@fchapoton
Copy link
Contributor

now in the rings and modular folders

sequel of #22871

part of #16072

CC: @jdemeyer @jhpalmieri @tscrim

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 3b2620f

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/22879
@fchapoton fchapoton added this to the sage-8.0 milestone Apr 26, 2017
@fchapoton
Copy link
Contributor Author

Commit: 4decf49

@fchapoton
Copy link
Contributor Author

New commits:

4decf49py3: use six.integer_types (step 2/2)

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/22879

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 26, 2017

Changed commit from 4decf49 to 3b2620f

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 26, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

3b2620ftrac 22879 one more use of six.integer_types

@jhpalmieri
Copy link
Member

comment:3

I just had a thought: should we have sage.integer_types, consisting of six.integer_types + (Integer,)? Then we could use that in most of the cases here and in #22871.

Edit: or sage.sage_integer_types or something similar. I'm not sure about the name.

@jhpalmieri
Copy link
Member

comment:4

In any case, all tests pass here.

@fchapoton
Copy link
Contributor Author

comment:5

so, is this a positive review ?

@jhpalmieri
Copy link
Member

comment:6

Sure, why not?

@jhpalmieri
Copy link
Member

Reviewer: John Palmieri

@vbraun
Copy link
Member

vbraun commented Apr 29, 2017

Changed branch from u/chapoton/22879 to 3b2620f

@vbraun vbraun closed this as completed in 2397568 Apr 29, 2017
@fchapoton fchapoton mentioned this issue Apr 29, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.0
Development

No branches or pull requests
3 participants
@vbraun @jhpalmieri @fchapoton