-
-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "long time" to doctests in the geometry component #22534
Comments
Branch: u/jipilab/22534 |
New commits:
|
Commit: |
comment:3
This change is bad and causing the doctest failure: diff --git a/src/sage/geometry/polyhedron/plot.py b/src/sage/geometry/polyhedron/plot.py
index a50eb16..4540377 100644
--- a/src/sage/geometry/polyhedron/plot.py
+++ b/src/sage/geometry/polyhedron/plot.py
@@ -88,7 +88,8 @@ def render_3d(projection, *args, **kwds):
Graphics3d Object
sage: Polyhedron(vertices=[[1,1,1]], lines=[[0,1,0],[0,0,1]]).plot() # R^2 in R^3
Graphics3d Object
- sage: Polyhedron(rays=[[0,1,0],[0,0,1]], lines=[[1,0,0]]).plot() # quadrant wedge in R^2
+ sage: Polyhedron(rays=[[0,1,0],[0,0,1]], lines=[[1,0,0]]).plot()
+ # long time quadrant wedge in R^2
Graphics3d Object
sage: Polyhedron(rays=[[0,1,0]], lines=[[1,0,0]]).plot() # upper half plane in R^3
Graphics3d Object You need the |
Reviewer: Travis Scrimshaw |
comment:5
Oh! Got it! Thanks for the pointer! JP |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:8
LGTM now. Thanks. |
Changed branch from u/jipilab/22534 to |
Making tests in the files in the geometry currently takes a long time.
We should add the markup
long time
next to the tests that take too long.CC: @fchapoton @videlec
Component: geometry
Keywords: days84
Author: Jean-Philippe Labbé
Branch/Commit:
f41f3a4
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/22534
The text was updated successfully, but these errors were encountered: