Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "long time" to doctests in the geometry component #22534

Closed
jplab opened this issue Mar 6, 2017 · 10 comments
Closed

Add "long time" to doctests in the geometry component #22534

jplab opened this issue Mar 6, 2017 · 10 comments

Comments

@jplab
Copy link

jplab commented Mar 6, 2017

Making tests in the files in the geometry currently takes a long time.

We should add the markup long time next to the tests that take too long.

CC: @fchapoton @videlec

Component: geometry

Keywords: days84

Author: Jean-Philippe Labbé

Branch/Commit: f41f3a4

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/22534

@jplab jplab added this to the sage-7.6 milestone Mar 6, 2017
@jplab
Copy link
Author

jplab commented Mar 6, 2017

Branch: u/jipilab/22534

@jplab
Copy link
Author

jplab commented Mar 6, 2017

New commits:

9fd724dAdded some long time markup

@jplab
Copy link
Author

jplab commented Mar 6, 2017

Commit: 9fd724d

@tscrim
Copy link
Collaborator

tscrim commented Mar 7, 2017

comment:3

This change is bad and causing the doctest failure:

diff --git a/src/sage/geometry/polyhedron/plot.py b/src/sage/geometry/polyhedron/plot.py
index a50eb16..4540377 100644
--- a/src/sage/geometry/polyhedron/plot.py
+++ b/src/sage/geometry/polyhedron/plot.py
@@ -88,7 +88,8 @@ def render_3d(projection, *args, **kwds):
         Graphics3d Object
         sage: Polyhedron(vertices=[[1,1,1]], lines=[[0,1,0],[0,0,1]]).plot()                  # R^2 in R^3
         Graphics3d Object
-        sage: Polyhedron(rays=[[0,1,0],[0,0,1]], lines=[[1,0,0]]).plot()                      # quadrant wedge in R^2
+        sage: Polyhedron(rays=[[0,1,0],[0,0,1]], lines=[[1,0,0]]).plot()
+        # long time quadrant wedge in R^2
         Graphics3d Object
         sage: Polyhedron(rays=[[0,1,0]], lines=[[1,0,0]]).plot()                              # upper half plane in R^3
         Graphics3d Object

You need the # long time on the same line, otherwise it is treated as output (see the patchbot).

@jdemeyer
Copy link

jdemeyer commented Mar 8, 2017

Reviewer: Travis Scrimshaw

@jplab
Copy link
Author

jplab commented Mar 8, 2017

comment:5

You need the # long time on the same line, otherwise it is treated as output (see the patchbot).

Oh! Got it! Thanks for the pointer!

JP

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 8, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

f41f3a4Corrected one long time comment

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 8, 2017

Changed commit from 9fd724d to f41f3a4

@tscrim
Copy link
Collaborator

tscrim commented Mar 8, 2017

comment:8

LGTM now. Thanks.

@vbraun
Copy link
Member

vbraun commented Mar 10, 2017

Changed branch from u/jipilab/22534 to f41f3a4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants