-
-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Sphinx 1.5.x #22252
Comments
comment:1
Should we update docutils to 0.13 at the same time? sphinx 1.5.2 as all the fix to work with it as far as I know, can be in a separate ticket but it is better if they are done at the same time given the comments in cschwan/sage-on-gentoo#451 |
comment:2
I would say: let's do whatever is easiest. So the question is: is it easier to make Sage and Sphinx-1.5.2 work with docutils-0.12 or with docutils-0.13? |
comment:3
Thinking more about it, sphinx 1.5.2 should work with both, so we can do sphinx first then docutils afterwards. |
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. New commits:
|
Commit: |
This comment has been minimized.
This comment has been minimized.
Author: Jeroen Demeyer |
comment:8
The line
from |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
Changed keywords from none to days85 |
comment:14
This last version actually manages to compile the documentation. |
comment:16
What about the issue in [comment:8]? Is ssl going to become a dependency for building the Sage docs? |
comment:17
Modulo [comment:8] it works for me. |
comment:18
I think SSl is going to be a Sage dependency soon anyway so that we can upgrade |
comment:19
In fact, SSL is already a Sage dependency: #22189. |
comment:39
Replying to @jdemeyer:
I agree. |
comment:40
I am happy with this, but it needs testing on platforms other than OS X. |
comment:41
Replying to @jdemeyer:
I should check that I can build it now. I changed system so I am starting from a cleaner slate. I used to have problem with russian documentation because of tex fonts problems. According to my ebuild I need the following from tex
I usually do
Gentoo doesn't install "unfolded" russian (and japanese?) tex fonts. If you don't specify VARTEX, it may try to do it in a system location. |
comment:42
Japanese pdf doc build OK here with this ticket as is (a vanilla build rather than a sage-on-gentoo one). Cannot quite read it but the "a_tour_of_sage.pdf" looks legit compared to the english one. |
comment:43
I have Gentoo here and all pdfs build with this ticket. I have installed
in Replying to @jdemeyer:
|
comment:44
Replying to @strogdon:
Can you elaborate Steve? Do you mean that after doing that change the fonts are installed and you don't need to set VARTEX, or that I should check my build for missing fonts? |
comment:45
Replying to @kiwifb:
This was with vanilla and not s-o-g. I just did |
comment:46
Replying to @strogdon:
It was |
comment:47
Still commented here, and yet I completed the build of the pdf documentation succesfully
|
comment:48
Replying to @kiwifb:
I don't think there is an issue. I'm redoing things. It will take a while. Things are quite slow. |
comment:49
OK, with
in
The same
I manually installed the packages - that that could be the difference? The only difference on my system is that |
comment:50
Since I had to build anew I also needed USE="cjk xetex", but you would have been prompted for those I am sure. On the other hand I found
Can you check that you have that? |
comment:51
On another note:
So I removed the |
comment:52
Replying to @kiwifb:
Yes, this file is on my system. |
comment:53
Hum... I don't any of the stuff you quote in my log. I am wondering if it is because I have fonts (truetype not tex) that have japanase character sets on my system.
|
comment:54
Replying to @kiwifb:
It appears that, for whatever reason, I had a
file that was getting in the way of the build. Moving the |
comment:55
Let me remind everybody that this ticket is about upgrading from Sphinx 1.4 to 1.5. Discussions about building docs in general can be good to have, but they do not belong on this ticket (unless there is a regression, i.e. something worked with Sphinx 1.4 but no longer works). |
comment:56
Sorry for the noise Jeroen. We wanted to be sure we had the dependencies right. My own experience here is that:
I am happy for this ticket to be sent to the bots once the offending patch is removed - or someone shows it is needed in some cases. |
comment:57
Replying to @kiwifb:
Can we leave this to a follow-up ticket? The patch has been added in the past for a reason, so I'm not too keen to just drop it. |
comment:58
Replying to @jdemeyer:
I am happy with that, we may well discover that is needed on some platforms. Putting it in positive review. |
Changed branch from u/jdemeyer/upgrade_to_sphinx_1_5_2 to |
The newer version of Sphinx needs
requests
.Tarballs:
We add a patch to Sphinx to allow running without SSL: sphinx-doc/sphinx#3554
Upstream: Fixed upstream, but not in a stable release.
CC: @kiwifb
Component: packages: standard
Keywords: days85
Author: Jeroen Demeyer
Branch/Commit:
f20f00a
Reviewer: François Bissey, John Palmieri
Issue created by migration from https://trac.sagemath.org/ticket/22252
The text was updated successfully, but these errors were encountered: