Shioda invariants for hyperelliptic curves with genus 3

[anna-somoza]

Sorina Ionica, Elisa Lorenzo Garcia and I implemented the computation of Shioda invariants for a given hyperelliptic curve of genus 3.

Following the implementation of the constructors of genus 2 curves over various fields we have added the corresponding classes for genus 3 hyperelliptic curves.

Depends on #26462
Depends on #27633

CC: @sagetrac-christelle @sagetrac-elorenzogarcia @sagetrac-ionisorus @mstreng @sagetrac-kohel @sagetrac-florian @JRSijsling @jnoordsij

Component: number theory

Keywords: days82, hyperelliptic curves, shioda invariants, days98

Author: Sorina Ionica, Elisa Lorenzo Garcia, Anna Somoza

Branch/Commit: public/22173 @ ca3b22c

Reviewer: Vincent Delecroix, Jean-Pierre Flori

Issue created by migration from https://trac.sagemath.org/ticket/22173

[anna-somoza]

Branch: u/annasomoza/22173-shiodainv

[sagetrac-git]

Commit: 2bc9d8e

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

87e7c25	work in progress
5a83cd4	Merge branch 'develop' into local-g3invariants
2bc9d8e	Add doctests

[sagetrac-git]

Changed commit from 2bc9d8e to 153178f

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

153178f

Fix extra empty lines

[fchapoton]

comment:5

missing "of" in

Compute invariants genus 2 and 3 hyperelliptic curves via 'Ueberschiebung'

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

4f8d45f	Fix output type
955cc72	Fix minor doc error

[sagetrac-git]

Changed commit from 153178f to 955cc72

[fchapoton]

comment:9

doc still does not build:

+[dochtml] [curves   ] /home/u1/chapoton/sage/local/lib/python2.7/site-packages/sage/schemes/hyperelliptic_curves/invariants.py:docstring of sage.schemes.hyperelliptic_curves.invariants.shioda_invariants:7: WARNING:
 Duplicate explicit target name: "sh".
+[dochtml] [curves   ] /home/u1/chapoton/sage/local/lib/python2.7/site-packages/sage/schemes/hyperelliptic_curves/invariants.py:docstring of sage.schemes.hyperelliptic_curves.invariants.shioda_invariants:7: WARNING:
 duplicate citation Sh, other instance in /home/u1/chapoton/sage/src/doc/en/reference/curves/sage/schemes/hyperelliptic_curves/invariants.rst

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

1da5c7e

Add Shioda computation for h neq 0. Doc builds.

[sagetrac-git]

Changed commit from 955cc72 to 1da5c7e

[fchapoton]

comment:11

some remarks:

• remove the commented code if it is useless

• reference [Sh] should go the master reference file (see http://doc.sagemath.org/html/en/developer/coding_basics.html#sage-s-master-bibliography-file)

• compile the html doc and look at it to check that it looks correct

• you could use "lazy import" for your new modules.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

b5cec8d	work in progress
abf1b10	Add doctests
6f89277	Fix extra empty lines
f8bd519	Fix output type
d20d1a2	Fix minor doc error
e9bf8ef	Add Shioda computation for h neq 0. Doc builds.
bd25753	Added lazy import of shioda_invariants. Reference [Sh] moved to master reference file as [Sh1967]. Doc builds.
f6c94f2	Resolve commit

[sagetrac-git]

Changed commit from 1da5c7e to f6c94f2

[sagetrac-git]

Changed commit from f6c94f2 to e1cee87

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

e1cee87

Added lazy import of shioda_invariants. Reference [Sh] moved to master reference file as [Sh1967]. Doc builds.

[fchapoton]

comment:17

Now that you have moved the reference [Sh1967] to the master reference file, you should update the remaining link [Sh]_ and replace

.. [Sh] etc

by

- [Sh1967]_

in the REFERENCE block.

[sagetrac-git]

Changed commit from e1cee87 to dfed7a9

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

dfed7a9

Remove remaining [Sh] reference.

[mkoeppe]

comment:51

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

[mkoeppe]

comment:52

Setting a new milestone for this ticket based on a cursory review.

[yyyyx4]

Changed branch from u/annasomoza/22173-shiodainv to public/22173

[yyyyx4]

Changed commit from f0d91de to d989bb7

[yyyyx4]

comment:53

I took the liberty to rebase this; no complications. Needs another review, and presumably also an OK from the authors.

Regarding #26462: This looks like a reminder to refactor things at some point rather than an actual dependency?

---

Last 10 new commits:

dfed7a9	Remove remaining [Sh] reference.
a6a9331	Change computation of shioda invariants of a curve (now consistent with magma). Fix copyright typos.
e455b4d	Merge remote-tracking branch 'origin/u/annasomoza/22173-shiodainv' into local-merge-22173
e51cb49	Changed to use dynamic class creation introduced in #27633
4a6a480	Merge branch 't/27633/redesign_of_the_constructor_for_hyperelliptic_curves' into local-merge-22173
90459d4	Merge branch 't/27633/redesign_of_the_constructor_for_hyperelliptic_curves' into local-merge-22173
eb73de8	Add inheritance test to doc.
dcff833	Remove unused variable
f0d91de	Merge with latest beta
d989bb7	Merge tag '9.5.beta2' into u/annasomoza/22173-shiodainv

[fchapoton]

comment:54

please remove from `future` import absolute_import

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

ca3b22c

remove `__future__` import

[sagetrac-git]

Changed commit from d989bb7 to ca3b22c

[mkoeppe]

comment:56

Stalled in needs_review or needs_info; likely won't make it into Sage 9.5.

[mkoeppe]

Branch has merge conflicts