Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyhedron.to_linear_program should select solver by base_ring #20415

Closed
mkoeppe opened this issue Apr 11, 2016 · 8 comments
Closed

Polyhedron.to_linear_program should select solver by base_ring #20415

mkoeppe opened this issue Apr 11, 2016 · 8 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 11, 2016

This is a follow-up on #20301.
#20296 provides a way to select a suitable solver by its base_ring.

Polyhedron.to_linear_program should do that.

Note, for exact polyhedra, this will change the behavior of to_linear_program from inexact computation to exact computation, which will be much slower (but note, speed is irrelevant for this method, because when the Polyhedron was set up, already the double description has been computed eagerly.)

To restore the old behavior, the user would need to pass an explicit base_ring=RDF or solver=... argument to to_linear_program.
(The patch adds many examples that illustrate this.)

CC: @dimpase @videlec @novoselt

Component: geometry

Author: Matthias Koeppe

Branch/Commit: 7b7aa5e

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/20415

@mkoeppe mkoeppe added this to the sage-7.2 milestone Apr 11, 2016
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 11, 2016

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 11, 2016

New commits:

20d6c5aget_backend: Pass base_ring to PPLBackend, raise an error if not QQ
4b42d4aget_solver: Take base_ring's fraction field
7b7aa5eto_linear_program: Select solver according to base_ring, which can be overriden by keyword argument

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 11, 2016

Commit: 7b7aa5e

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@dimpase
Copy link
Member

dimpase commented Apr 11, 2016

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Apr 11, 2016

comment:4

looks good to me.

@vbraun
Copy link
Member

vbraun commented Apr 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants