Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix integer option and a bug in Delsarte bounds code #20367

Closed
dimpase opened this issue Apr 6, 2016 · 9 comments
Closed

fix integer option and a bug in Delsarte bounds code #20367

dimpase opened this issue Apr 6, 2016 · 9 comments

Comments

@dimpase
Copy link
Member

dimpase commented Apr 6, 2016

with PPL providing MIP solver thanks to #20354 and #20351, it becomes important to have an option to ask for integer solutions only. A silly bug is fixed along the way.

Depends on #20351
Depends on #20354
Depends on #20361

CC: @mkoeppe

Component: coding theory

Author: Dima Pasechnik

Branch/Commit: eb15d11

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/20367

@dimpase dimpase added this to the sage-7.2 milestone Apr 6, 2016
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 6, 2016

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

728750fCVXOPTBackend.add_variables: Pass arguments to add_variable, correct default for lower_bound
b4a8ed7Copy new CVXOPTBackend.add_variables tests to other backends
b0d89e4GLPKBackend.add_variables: Set column names correctly
183ce25PPLBackend.add_variable, add_variables: Don't silently ignore binary=True, integer=True
e47b608CVXOPTBackend.add_linear_constraints: Add doctest, simplify code
b0179c2Merge branch 't/20303/fixes_for_the_cvxopt_mip_backend' into t/20354/pplbackend__add_support_for_integer_variables
144a970PPLBackend: Add support for integer variables
df42b5bFix for #20361: PPL backend re-solves the problem every time get_variable_value or get_objective_value is called
1931b2aMerge branch 'u/mkoeppe/ppl_backend_re_solves_the_problem_every_time_get_variable_value_or_get_objective_value_is_called' of git://trac.sagemath.org/sage into delsartefix
115092cproper handling of isinteger parameter, new doctest

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 6, 2016

Commit: 115092c

@dimpase
Copy link
Member Author

dimpase commented Apr 6, 2016

Changed dependencies from #20351, #20354 to #20351, #20354, #20361

@dimpase
Copy link
Member Author

dimpase commented Apr 6, 2016

Last 10 new commits:

728750fCVXOPTBackend.add_variables: Pass arguments to add_variable, correct default for lower_bound
b4a8ed7Copy new CVXOPTBackend.add_variables tests to other backends
b0d89e4GLPKBackend.add_variables: Set column names correctly
183ce25PPLBackend.add_variable, add_variables: Don't silently ignore binary=True, integer=True
e47b608CVXOPTBackend.add_linear_constraints: Add doctest, simplify code
b0179c2Merge branch 't/20303/fixes_for_the_cvxopt_mip_backend' into t/20354/pplbackend__add_support_for_integer_variables
144a970PPLBackend: Add support for integer variables
df42b5bFix for #20361: PPL backend re-solves the problem every time get_variable_value or get_objective_value is called
1931b2aMerge branch 'u/mkoeppe/ppl_backend_re_solves_the_problem_every_time_get_variable_value_or_get_objective_value_is_called' of git://trac.sagemath.org/sage into delsartefix
115092cproper handling of isinteger parameter, new doctest

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 6, 2016

comment:3

delsarte_bound_additive_hamming_space should perhaps have a test involving isinteger=True?

Looking at the file, perhaps the English transliteration Kravchuk should be made an alias for the French transliteration Krawtchouk?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 6, 2016

Changed commit from 115092c to eb15d11

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 6, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

eb15d11added Kravchuk and tests

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 6, 2016

Reviewer: Matthias Koeppe

@vbraun
Copy link
Member

vbraun commented Apr 8, 2016

Changed branch from u/dimpase/delsartefix to eb15d11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants