test improved evaluation of trigonometric functions and complex exponential function

[behackl]

In the current development version of pynac the evaluation of trigonometric functions has been improved. This enables the following behavior:

sage: var('k', domain='integer')
k
sage: sin(k*pi)
0
sage: cos(k*pi)
(-1)^k
sage: sin(1 + 2*k*pi)
sin(1)
sage: tan(k*pi)
0
sage: cos(2*k*pi + pi/3)
1/2

and so on. Additionally, this introduces simplification for the complex exponential function:

sage: exp(2*k*pi*I)
sage: 1

This ticket shall document these changes.

Depends on #20134

CC: @rwst

Component: symbolics

Keywords: pynac

Author: Benjamin Hackl

Branch/Commit: edec004

Reviewer: Ralf Stephan, Julian Rüth, Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/20099

[behackl]

Changed dependencies from pynac-0.6.3 to #20134

[behackl]

Branch: u/behackl/symbolic/period-reduction-doctests

[behackl]

New commits:

9db23de	package version / checksum
7785109	coth/acoth BuiltinFunction --> GinacFunction and fixes
2fab819	doctest fixes
867bd3d	doctests for reduction of exp-arguments
f868e90	doctests for argument reduction of sin, cos, tan
16045ae	additional doctest for computation of residues

[behackl]

Commit: 16045ae

[rwst]

Reviewer: Ralf Stephan

[rwst]

comment:3

Can be set positive as soon as the dependency is reviewed.

[rwst]

comment:6

Needs merge.

[sagetrac-git]

Changed commit from 16045ae to 871c4c9

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

871c4c9

Merge tag '7.2.beta1' into symbolic/period-reduction-doctests

[behackl]

comment:8

Done, back to needs_review.

[saraedum]

Author: Benjamin Hackl

[saraedum]

comment:10

I think "For the sake of simplification, the argument is reduced the period of the complex exponential function" is missing a "modulo" or something like that. Once that is fixed, feel free to set it to positive review yourself.

[saraedum]

Changed reviewer from Ralf Stephan to Ralf Stephan, Julian Rüth

[fchapoton]

New commits:

5b01423	trac 23030 removing bad apply
7b4ec6c	Add sys.version_info as "PYTHON_VERSION" to cython compile-time environment
71b68d2	tract #22305 -- split off del_dictitem_by_exact_value and compile conditionally based on Py2/Py3
54d8c2d	Correction: Py3 does provide PyDict_GetItemWithError but Cython doesn't provide it yet
5bc719c	Merge branch 'public/22305' of ssh://trac.sagemath.org:22/sage into test
adabef0	Merge branch 'u/behackl/symbolic/period-reduction-doctests' in 8.0.b7
e91dda2	trac 20099 details

[fchapoton]

Changed commit from 871c4c9 to e91dda2

[fchapoton]

Changed branch from u/behackl/symbolic/period-reduction-doctests to public/20099

[sagetrac-git]

Changed commit from e91dda2 to edec004

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

6e90839	Merge branch 'u/behackl/symbolic/period-reduction-doctests' in 8.0.b7
edec004	trac 20099 details

[tscrim]

comment:15

LGTM.

[tscrim]

Changed reviewer from Ralf Stephan, Julian Rüth to Ralf Stephan, Julian Rüth, Travis Scrimshaw

[vbraun]

Changed branch from public/20099 to edec004