Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete empty directories in $SAGE_DOC #20010

Closed
jdemeyer opened this issue Feb 4, 2016 · 10 comments
Closed

Delete empty directories in $SAGE_DOC #20010

jdemeyer opened this issue Feb 4, 2016 · 10 comments

Comments

@jdemeyer
Copy link

jdemeyer commented Feb 4, 2016

In #19127, the automatic deleting of empty directories was removed, because of the mistaken assumption that it was not needed. While it's not needed in all cases, it is needed in one case:

it can happen that git checkout leaves behind an empty directory (since it does not track directories), for example src/doc/en/reference/manifolds. These directories should be deleted, otherwise Sphinx complains.

CC: @hivert @mezzarobba

Component: build

Author: Jeroen Demeyer

Branch/Commit: cabdf45

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/20010

@jdemeyer jdemeyer added this to the sage-7.1 milestone Feb 4, 2016
@jdemeyer
Copy link
Author

jdemeyer commented Feb 4, 2016

Dependencies: #19127

@jdemeyer
Copy link
Author

jdemeyer commented Feb 4, 2016

Author: Jeroen Demeyer

@jdemeyer
Copy link
Author

jdemeyer commented Feb 5, 2016

@jdemeyer
Copy link
Author

jdemeyer commented Feb 5, 2016

New commits:

cabdf45Delete empty directories in $SAGE_DOC before running Sphinx

@jdemeyer
Copy link
Author

jdemeyer commented Feb 5, 2016

Commit: cabdf45

@jdemeyer
Copy link
Author

Changed dependencies from #19127 to none

@jdemeyer

This comment has been minimized.

@jhpalmieri
Copy link
Member

comment:5

Looks good. With previous versions of docbuilding, there were many empty directories and so I objected to printing out the message Deleting empty directory ... for each one. With this version, we should usually have just a few empty directories, if any, so it's fine to print it.

@jhpalmieri
Copy link
Member

Reviewer: John Palmieri

@vbraun
Copy link
Member

vbraun commented Feb 20, 2016

Changed branch from u/jdemeyer/delete_empty_directories_in__sage_doc to cabdf45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants