Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exact_part for asymptotic expansions #19931

Closed
behackl opened this issue Jan 21, 2016 · 12 comments
Closed

exact_part for asymptotic expansions #19931

behackl opened this issue Jan 21, 2016 · 12 comments

Comments

@behackl
Copy link
Member

behackl commented Jan 21, 2016

For various reasons, having a method expansion.exact_part that returns the asymptotic expansion that consists of all ExactTerm-summands would be very useful.

This ticket provides such a method.

CC: @dkrenn @cheuberg

Component: asymptotic expansions

Author: Benjamin Hackl

Branch/Commit: 7276172

Reviewer: Clemens Heuberger

Issue created by migration from https://trac.sagemath.org/ticket/19931

@behackl
Copy link
Member Author

behackl commented Jan 21, 2016

Author: Benjamin Hackl

@behackl
Copy link
Member Author

behackl commented Jan 21, 2016

Commit: 8aa55e2

@behackl
Copy link
Member Author

behackl commented Jan 21, 2016

New commits:

8aa55e2implement exact_part

@behackl

This comment has been minimized.

@behackl
Copy link
Member Author

behackl commented Jan 21, 2016

Branch: u/behackl/asy/exact_part

@cheuberg
Copy link
Contributor

comment:2

I'd prefer to copy the expression and to delete all non-exact elements. In general, this should be more efficient than recreating a poset with almost all elements --- after all, in general, there will be more exact terms than error terms.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 21, 2016

Changed commit from 8aa55e2 to 7276172

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 21, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

7276172delete terms from copy instead of building new poset

@behackl
Copy link
Member Author

behackl commented Jan 21, 2016

comment:4

Replying to @cheuberg:

I'd prefer to copy the expression and to delete all non-exact elements. In general, this should be more efficient than recreating a poset with almost all elements --- after all, in general, there will be more exact terms than error terms.

I agree, this strategy seems to be more efficient than building the entire expansion again. I've adapted the implementation.

@cheuberg
Copy link
Contributor

Reviewer: Clemens Heuberger

@cheuberg
Copy link
Contributor

comment:5

Doctests pass according to patchbot, documentation builds, code now fine.

@vbraun
Copy link
Member

vbraun commented Jan 24, 2016

Changed branch from u/behackl/asy/exact_part to 7276172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants