Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

difference of behavior in polyhedra with different backends #19803

Closed
videlec opened this issue Dec 30, 2015 · 10 comments
Closed

difference of behavior in polyhedra with different backends #19803

videlec opened this issue Dec 30, 2015 · 10 comments

Comments

@videlec
Copy link
Contributor

videlec commented Dec 30, 2015

The following error used to occur:

sage: from sage.geometry.polyhedron.parent import Polyhedra
sage: P_ppl = Polyhedra(ZZ, 3, 'ppl')
sage: P_cdd = Polyhedra(ZZ, 3, 'cdd')
sage: P_ppl([[],[],[]], None)
The empty polyhedron in ZZ^3
sage: P_cdd([[],[],[]], None)
Traceback (most recent call last):
...
TypeError: can't multiply sequence by non-int of type 'NoneType'

Apparently it got fixed along the way and we add doctests verifying it.

CC: @vbraun @jplab @mo271

Component: geometry

Keywords: empty polyhedron, cdd

Author: Jonathan Kliem

Branch/Commit: 96dad18

Reviewer: Laith Rastanawi

Issue created by migration from https://trac.sagemath.org/ticket/19803

@videlec videlec added this to the sage-7.0 milestone Dec 30, 2015
@jplab
Copy link

jplab commented Mar 15, 2017

comment:1

This might be related to #17339.

@jplab
Copy link

jplab commented Apr 8, 2018

comment:2

This is because the cdd backend does not have an _init_empty_polyhedron method. That should be an easy fix.

The problem in the description is that it tries to get the common length of elements in the v-representation while they are all None. This should be grabbed beforehand and initialize an empty polyhedron like we do in the other cases.

@kliem
Copy link
Contributor

kliem commented Jan 8, 2020

Changed keywords from none to empty polyhedron, cdd

@kliem
Copy link
Contributor

kliem commented Jan 8, 2020

Commit: 96dad18

@kliem
Copy link
Contributor

kliem commented Jan 8, 2020

Branch: public/19803

@kliem
Copy link
Contributor

kliem commented Jan 8, 2020

comment:4

Looks like this got fixed along the way.


New commits:

96dad18add doctests that cdd can handle empty polyhedron now

@kliem

This comment has been minimized.

@kliem
Copy link
Contributor

kliem commented Jan 8, 2020

Author: Jonathan Kliem

@kliem kliem modified the milestones: sage-7.0, sage-9.1 Jan 8, 2020
@LaisRast
Copy link

Reviewer: Laith Rastanawi

@vbraun
Copy link
Member

vbraun commented Jan 11, 2020

Changed branch from public/19803 to 96dad18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants