Update sagenb #19616

kcrisman · 2015-11-23T15:45:59Z

It's time again to update sagenb. Package at http://www.math-cs.gordon.edu/~kcrisman/sagenb-0.11.6.1.tar

Note there is a circular dependency with #10295: both tickets need to be merged together.

Depends on #19671
Depends on #10295

CC: @novoselt @kiwifb

Component: notebook

Author: Karl-Dieter Crisman

Branch/Commit: bed31b2

Reviewer: Jeroen Demeyer, Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/19616

The text was updated successfully, but these errors were encountered:

kcrisman · 2015-12-01T04:46:08Z

comment:2

I'll remove the dependency if it doesn't make progress, since there are several other things we would want to update anyway.

jdemeyer · 2015-12-01T09:32:47Z

comment:3

Replying to @kcrisman:

I'll remove the dependency if it doesn't make progress, since there are several other things we would want to update anyway.

Is it really required that sagenb and pexpect are upgraded together? I haven't looked at #10295 since it depends on this ticket.

kcrisman · 2015-12-01T14:52:30Z

comment:4

I'll remove the dependency if it doesn't make progress, since there are several other things we would want to update anyway.

Is it really required that sagenb and pexpect are upgraded together? I haven't looked at #10295 since it depends on this ticket.

You'd have to ask François, but my understanding of what he said is that this is indeed necessary for that commit.

jdemeyer · 2015-12-01T15:06:02Z

comment:6

Note that there is a circular dependency with #10295. Can somebody please clarify?

kcrisman · 2015-12-01T15:14:12Z

comment:7

Note that there is a circular dependency with #10295. Can somebody please clarify?

Again, fbissey said that the packages need to be updated simultaneously; assuming that this ticket ends up including this commit, then this ticket would be the one.

jdemeyer · 2015-12-01T15:19:58Z

comment:8

OK, I understand now, thanks for the pointer.

To resolve the deadlock situation: can somebody arrange for this ticket to be set to needs_review?

kcrisman · 2015-12-01T15:25:01Z

comment:9

Got it, I see the problem on your side now.

I can package up what we have if you are willing to review that commit (which is surely a trivial thing, I just haven't tested it). I still want to merge sagemath/sagenb#324 and sagemath/sagenb#345 but will try to set aside some time for that this afternoon (US) and then package up a sagenb update for this purpose.

kcrisman · 2015-12-01T18:58:03Z

comment:10

I'm going to make a separate package with other changes for this ticket, and then a followup for #10295. Hopefully done within a couple hours (lots of other things going on today).

kcrisman · 2015-12-02T02:25:59Z

comment:11

Ran into trouble with one of the updates not passing tests but I'm still going to decouple these.

kcrisman · 2015-12-02T02:25:59Z

Changed dependencies from #10295 to none

jdemeyer · 2015-12-02T08:45:51Z

comment:12

If you want to add a sagenb package for #10295, just add it on #10295 instead of a separate ticket.

kcrisman · 2015-12-02T13:46:29Z

comment:13

Yes, that was my plan.

kcrisman · 2015-12-03T03:34:22Z

Branch: u/kcrisman/ticket/19616

kcrisman · 2015-12-03T03:44:52Z

Commit: fd1ec53

kcrisman · 2015-12-03T03:44:52Z

New commits:

`fd1ec53`	`Upgrade sagenb to version 0.11.5`

kcrisman · 2015-12-03T03:44:52Z

Author: Karl-Dieter Crisman

jdemeyer · 2015-12-04T18:30:51Z

comment:17

Could you also make a sagenb version 0.11.6 for #10295? Then I could just test 0.11.6 and test both tickets at the same time.

kcrisman · 2015-12-04T18:33:40Z

comment:18

I won't make a full release, in case it turns out that doesn't get merged very quickly, but I'll make a version just for you and that ticket for testing purposes only.

jdemeyer · 2015-12-04T21:32:38Z

comment:19

Replying to @kcrisman:

I won't make a full release, in case it turns out that doesn't get merged very quickly, but I'll make a version just for you and that ticket for testing purposes only.

What is the difference between a "full release" and a release "for testing purposes only"?

jdemeyer · 2015-12-04T21:34:56Z

comment:20

The documentation doesn't build:

# Sphinx version: 1.2.2
# Python version: 2.7.9
# Docutils version: 0.12 release
# Jinja2 version: 2.7.3
# Loaded extensions:
#   sphinx.ext.graphviz from /usr/local/src/sage-config/local/lib/python2.7/site-packages/Sphinx-1.2.2-py2.7.egg/sphinx/ext/graphviz.pyc
#   sphinx.ext.inheritance_diagram from /usr/local/src/sage-config/local/lib/python2.7/site-packages/Sphinx-1.2.2-py2.7.egg/sphinx/ext/inheritance_diagram.pyc
#   matplotlib.sphinxext.plot_directive from /usr/local/src/sage-config/local/lib/python2.7/site-packages/matplotlib-1.4.3-py2.7-linux-x86_64.egg/matplotlib/sphinxext/plot_directive.pyc
#   sphinx.ext.extlinks from /usr/local/src/sage-config/local/lib/python2.7/site-packages/Sphinx-1.2.2-py2.7.egg/sphinx/ext/extlinks.pyc
#   inventory_builder from /usr/local/src/sage-config/src/doc/common/inventory_builder.pyc
#   sage_autodoc from /usr/local/src/sage-config/src/doc/common/sage_autodoc.pyc
#   sphinx.ext.todo from /usr/local/src/sage-config/local/lib/python2.7/site-packages/Sphinx-1.2.2-py2.7.egg/sphinx/ext/todo.pyc
#   sphinx.ext.mathjax from /usr/local/src/sage-config/local/lib/python2.7/site-packages/Sphinx-1.2.2-py2.7.egg/sphinx/ext/mathjax.pyc
#   sphinx.ext.oldcmarkup from /usr/local/src/sage-config/local/lib/python2.7/site-packages/Sphinx-1.2.2-py2.7.egg/sphinx/ext/oldcmarkup.pyc
#   multidocs from /usr/local/src/sage-config/src/doc/common/multidocs.pyc
Traceback (most recent call last):
  File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/Sphinx-1.2.2-py2.7.egg/sphinx/cmdline.py", line 254, in main
    app.build(force_all, filenames)
  File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/Sphinx-1.2.2-py2.7.egg/sphinx/application.py", line 212, in build
    self.builder.build_update()
  File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/Sphinx-1.2.2-py2.7.egg/sphinx/builders/__init__.py", line 214, in build_update
    'out of date' % len(to_build))
  File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/Sphinx-1.2.2-py2.7.egg/sphinx/builders/__init__.py", line 234, in build
    purple, length):
  File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/Sphinx-1.2.2-py2.7.egg/sphinx/builders/__init__.py", line 134, in status_iterator
    for item in iterable:
  File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/Sphinx-1.2.2-py2.7.egg/sphinx/environment.py", line 480, in update_generator
    self.read_doc(docname, app=app)
  File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/Sphinx-1.2.2-py2.7.egg/sphinx/environment.py", line 627, in read_doc
    pub.publish()
  File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/docutils/core.py", line 217, in publish
    self.settings)
  File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/docutils/readers/__init__.py", line 72, in read
    self.parse()
  File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/docutils/readers/__init__.py", line 78, in parse
    self.parser.parse(self.input, document)
  File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/docutils/parsers/rst/__init__.py", line 172, in parse
    self.statemachine.run(inputlines, document, inliner=self.inliner)
  File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/docutils/parsers/rst/states.py", line 170, in run
    input_source=document['source'])
  File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/docutils/statemachine.py", line 239, in run
    context, state, transitions)
  File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/docutils/statemachine.py", line 460, in check_line
    return method(match, context, next_state)
  File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/docutils/parsers/rst/states.py", line 2726, in underline
    self.section(title, source, style, lineno - 1, messages)
  File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/docutils/parsers/rst/states.py", line 327, in section
    self.new_subsection(title, lineno, messages)
  File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/docutils/parsers/rst/states.py", line 395, in new_subsection
    node=section_node, match_titles=True)
  File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/docutils/parsers/rst/states.py", line 282, in nested_parse
    node=node, match_titles=match_titles)
  File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/docutils/parsers/rst/states.py", line 195, in run
    results = StateMachineWS.run(self, input_lines, input_offset)
  File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/docutils/statemachine.py", line 239, in run
    context, state, transitions)
  File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/docutils/statemachine.py", line 460, in check_line
    return method(match, context, next_state)
  File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/docutils/parsers/rst/states.py", line 2301, in explicit_markup
    self.explicit_list(blank_finish)
  File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/docutils/parsers/rst/states.py", line 2331, in explicit_list
    match_titles=self.state_machine.match_titles)
  File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/docutils/parsers/rst/states.py", line 319, in nested_list_parse
    node=node, match_titles=match_titles)
  File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/docutils/parsers/rst/states.py", line 195, in run
    results = StateMachineWS.run(self, input_lines, input_offset)
  File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/docutils/statemachine.py", line 239, in run
    context, state, transitions)
  File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/docutils/statemachine.py", line 460, in check_line
    return method(match, context, next_state)
  File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/docutils/parsers/rst/states.py", line 2604, in explicit_markup
    nodelist, blank_finish = self.explicit_construct(match)
  File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/docutils/parsers/rst/states.py", line 2311, in explicit_construct
    return method(self, expmatch)
  File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/docutils/parsers/rst/states.py", line 2054, in directive
    directive_class, match, type_name, option_presets)
  File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/docutils/parsers/rst/states.py", line 2103, in run_directive
    result = directive_instance.run()
  File "/usr/local/src/sage-config/src/doc/common/sage_autodoc.py", line 1168, in run
    documenter.generate(more_content=self.content)
  File "/usr/local/src/sage-config/src/doc/common/sage_autodoc.py", line 680, in generate
    self.document_members(all_members)
  File "/usr/local/src/sage-config/src/doc/common/sage_autodoc.py", line 576, in document_members
    for (mname, member, isattr) in self.filter_members(members, want_all):
  File "/usr/local/src/sage-config/src/doc/common/sage_autodoc.py", line 535, in filter_members
    doc = sage_getdoc_original(member)
  File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/sage/misc/sageinspect.py", line 1698, in sage_getdoc_original
    s,argspec = _extract_embedded_signature(_sage_getdoc_unformatted(obj), typ.__name__)
  File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/sage/misc/sageinspect.py", line 1613, in _sage_getdoc_unformatted
    r = obj._sage_doc_()
  File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/Werkzeug-0.11.2-py2.7.egg/werkzeug/local.py", line 342, in __getattr__
    return getattr(self._get_current_object(), name)
  File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/Werkzeug-0.11.2-py2.7.egg/werkzeug/local.py", line 301, in _get_current_object
    return self.__local()
  File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/Flask-0.10.1-py2.7.egg/flask/globals.py", line 34, in _find_app
    raise RuntimeError('working outside of application context')
RuntimeError: working outside of application context

jdemeyer · 2015-12-04T21:55:23Z

Changed branch from u/kcrisman/ticket/19616 to u/jdemeyer/ticket/19616

kcrisman · 2015-12-13T03:47:21Z

comment:44

Needs review - not a bad idea to just check things out again, hopefully it will also work well in the 6.11 betas.

jdemeyer · 2015-12-13T09:43:27Z

comment:45

Does this include the fix for #10295?

kcrisman · 2015-12-13T21:09:58Z

comment:46

Would I have released this new one otherwise? You also could have just checked the github:

jdemeyer · 2015-12-14T09:17:53Z

comment:47

Replying to @kcrisman:

Would I have released this new one otherwise?

I have no idea really. It's hard to follow what is happening precisely. I will update #10295.

jdemeyer · 2015-12-14T11:19:43Z

comment:48

This commit is causing doctest failures

sage -t --long local/lib/python2.7/site-packages/sagenb-0.11.6-py2.7.egg/sagenb/notebook/docHTMLProcessor.py
**********************************************************************
File "local/lib/python2.7/site-packages/sagenb-0.11.6-py2.7.egg/sagenb/notebook/docHTMLProcessor.py", line 154, in sagenb.notebook.docHTMLProcessor.genericHTMLProcessor.process_doc_html
Failed example:
    txt
Expected:
    '<h1 class="title">Title</h1>\n\n<p>nSome text</p>\n\n\n\n'
Got:
    u'<h1 class="title">Title</h1>\n\n<p>nSome text</p>\n\n\n\n'
**********************************************************************
File "local/lib/python2.7/site-packages/sagenb-0.11.6-py2.7.egg/sagenb/notebook/docHTMLProcessor.py", line 199, in sagenb.notebook.docHTMLProcessor.genericHTMLProcessor.hand_off_temp_pieces
Failed example:
    p.all_pieces
Expected:
    'a lot of stuff done bunch of tmp strings'
Got:
    u'a lot of stuff done bunch of tmp strings'
**********************************************************************
File "local/lib/python2.7/site-packages/sagenb-0.11.6-py2.7.egg/sagenb/notebook/docHTMLProcessor.py", line 323, in sagenb.notebook.docHTMLProcessor.genericHTMLProcessor.process_cell_input_output
Failed example:
    p.process_cell_input_output(s)
Expected:
    '\n{{{id=0|\n4 + 4\n///\n8\n}}}\n\n'
Got:
    u'\n{{{id=0|\n4 + 4\n///\n8\n}}}\n\n'
**********************************************************************
File "local/lib/python2.7/site-packages/sagenb-0.11.6-py2.7.egg/sagenb/notebook/docHTMLProcessor.py", line 426, in sagenb.notebook.docHTMLProcessor.genericHTMLProcessor.unknown_starttag
Failed example:
    p.temp_pieces
Expected:
    ['bunch ', 'of ', 'tmp ', 'strings', '<style type="text/css">']
Got:
    ['bunch ', 'of ', 'tmp ', 'strings', u'<style type="text/css">']
**********************************************************************
File "local/lib/python2.7/site-packages/sagenb-0.11.6-py2.7.egg/sagenb/notebook/docHTMLProcessor.py", line 449, in sagenb.notebook.docHTMLProcessor.genericHTMLProcessor.unknown_endtag
Failed example:
    p.temp_pieces
Expected:
    ['bunch ', 'of ', 'tmp ', 'strings', '</head>'] 
Got:
    ['bunch ', 'of ', 'tmp ', 'strings', u'</head>']
**********************************************************************
File "local/lib/python2.7/site-packages/sagenb-0.11.6-py2.7.egg/sagenb/notebook/docHTMLProcessor.py", line 492, in sagenb.notebook.docHTMLProcessor.genericHTMLProcessor.handle_charref
Failed example:
    p.temp_pieces
Expected:
    ['bunch ', 'of ', 'tmp ', 'strings', '&#160;']
Got:
    ['bunch ', 'of ', 'tmp ', 'strings', u'&#160;']
**********************************************************************
File "local/lib/python2.7/site-packages/sagenb-0.11.6-py2.7.egg/sagenb/notebook/docHTMLProcessor.py", line 514, in sagenb.notebook.docHTMLProcessor.genericHTMLProcessor.handle_entityref
Failed example:
    p.temp_pieces
Expected:
    ['bunch ', 'of ', 'tmp ', 'strings', '&160']
Got:
    ['bunch ', 'of ', 'tmp ', 'strings', u'&160']
**********************************************************************
File "local/lib/python2.7/site-packages/sagenb-0.11.6-py2.7.egg/sagenb/notebook/docHTMLProcessor.py", line 537, in sagenb.notebook.docHTMLProcessor.genericHTMLProcessor.handle_comment
Failed example:
    p.temp_pieces
Expected:
    ['bunch ', 'of ', 'tmp ', 'strings', '<!--important comment-->'] 
Got:
    ['bunch ', 'of ', 'tmp ', 'strings', u'<!--important comment-->']
**********************************************************************
File "local/lib/python2.7/site-packages/sagenb-0.11.6-py2.7.egg/sagenb/notebook/docHTMLProcessor.py", line 560, in sagenb.notebook.docHTMLProcessor.genericHTMLProcessor.handle_pi
Failed example:
    p.temp_pieces
Expected:
    ['bunch ', 'of ', 'tmp ', 'strings', '<?instructions>'] 
Got:
    ['bunch ', 'of ', 'tmp ', 'strings', u'<?instructions>']
**********************************************************************
File "local/lib/python2.7/site-packages/sagenb-0.11.6-py2.7.egg/sagenb/notebook/docHTMLProcessor.py", line 582, in sagenb.notebook.docHTMLProcessor.genericHTMLProcessor.handle_decl
Failed example:
    p.temp_pieces
Expected:
    ['bunch ', 'of ', 'tmp ', 'strings', '<!declaration>'] 
Got:
    ['bunch ', 'of ', 'tmp ', 'strings', u'<!declaration>']
**********************************************************************
File "local/lib/python2.7/site-packages/sagenb-0.11.6-py2.7.egg/sagenb/notebook/docHTMLProcessor.py", line 672, in sagenb.notebook.docHTMLProcessor.SphinxHTMLProcessor.reset
Failed example:
    d.all_pieces
Expected:
    ''
Got:
    u''
**********************************************************************
File "local/lib/python2.7/site-packages/sagenb-0.11.6-py2.7.egg/sagenb/notebook/docHTMLProcessor.py", line 748, in sagenb.notebook.docHTMLProcessor.SphinxHTMLProcessor.start_div
Failed example:
    p.all_pieces
Expected:
    'a lot of stuff done bunch of tmp strings' 
Got:
    u'a lot of stuff done bunch of tmp strings'
**********************************************************************
File "local/lib/python2.7/site-packages/sagenb-0.11.6-py2.7.egg/sagenb/notebook/docHTMLProcessor.py", line 765, in sagenb.notebook.docHTMLProcessor.SphinxHTMLProcessor.start_div
Failed example:
    p.temp_pieces
Expected:
    ['bunch ', 'of ', 'tmp ', 'strings', '<div class="something-else">']
Got:
    ['bunch ', 'of ', 'tmp ', 'strings', u'<div class="something-else">']
**********************************************************************
File "local/lib/python2.7/site-packages/sagenb-0.11.6-py2.7.egg/sagenb/notebook/docHTMLProcessor.py", line 826, in sagenb.notebook.docHTMLProcessor.SphinxHTMLProcessor.end_div
Failed example:
    p.temp_pieces
Expected:
    ['bunch ', 'of ', 'tmp ', 'strings', '<div class="something-else">', 'some data', '</div>']
Got:
    ['bunch ',
     'of ',
     'tmp ',
     'strings',
     u'<div class="something-else">',
     'some data',
     u'</div>']
**********************************************************************
File "local/lib/python2.7/site-packages/sagenb-0.11.6-py2.7.egg/sagenb/notebook/docHTMLProcessor.py", line 873, in sagenb.notebook.docHTMLProcessor.SphinxHTMLProcessor.start_pre
Failed example:
    p.temp_pieces
Expected:
    ['bunch ', 'of ', 'tmp ', 'strings', '<pre>'] 
Got:
    ['bunch ', 'of ', 'tmp ', 'strings', u'<pre>']
**********************************************************************
File "local/lib/python2.7/site-packages/sagenb-0.11.6-py2.7.egg/sagenb/notebook/docHTMLProcessor.py", line 907, in sagenb.notebook.docHTMLProcessor.SphinxHTMLProcessor.end_pre
Failed example:
    p.temp_pieces
Expected:
    ['bunch ', 'of ', 'tmp ', 'strings', '</pre>'] 
Got:
    ['bunch ', 'of ', 'tmp ', 'strings', u'</pre>']
**********************************************************************
File "local/lib/python2.7/site-packages/sagenb-0.11.6-py2.7.egg/sagenb/notebook/docHTMLProcessor.py", line 933, in sagenb.notebook.docHTMLProcessor.SphinxHTMLProcessor.start_form
Failed example:
    p.all_pieces
Expected:
    'a lot of stuff done bunch of tmp strings' 
Got:
    u'a lot of stuff done bunch of tmp strings'
**********************************************************************
File "local/lib/python2.7/site-packages/sagenb-0.11.6-py2.7.egg/sagenb/notebook/docHTMLProcessor.py", line 996, in sagenb.notebook.docHTMLProcessor.SphinxHTMLProcessor.start_span
Failed example:
    p.temp_pieces
Expected:
    ['bunch ', 'of ', 'tmp ', 'strings', '<span>'] 
Got:
    ['bunch ', 'of ', 'tmp ', 'strings', u'<span>']
**********************************************************************
File "local/lib/python2.7/site-packages/sagenb-0.11.6-py2.7.egg/sagenb/notebook/docHTMLProcessor.py", line 1029, in sagenb.notebook.docHTMLProcessor.SphinxHTMLProcessor.end_span
Failed example:
    p.temp_pieces
Expected:
    ['bunch ', 'of ', 'tmp ', 'strings', '</span>'] 
Got:
    ['bunch ', 'of ', 'tmp ', 'strings', u'</span>']
**********************************************************************
File "local/lib/python2.7/site-packages/sagenb-0.11.6-py2.7.egg/sagenb/notebook/docHTMLProcessor.py", line 1111, in sagenb.notebook.docHTMLProcessor.docutilsHTMLProcessor.reset
Failed example:
    d.all_pieces
Expected:
    ''
Got:
    u''
**********************************************************************
File "local/lib/python2.7/site-packages/sagenb-0.11.6-py2.7.egg/sagenb/notebook/docHTMLProcessor.py", line 1183, in sagenb.notebook.docHTMLProcessor.docutilsHTMLProcessor.start_pre
Failed example:
    p.all_pieces
Expected:
    'a lot of stuff done bunch of tmp strings' 
Got:
    u'a lot of stuff done bunch of tmp strings'
**********************************************************************
File "local/lib/python2.7/site-packages/sagenb-0.11.6-py2.7.egg/sagenb/notebook/docHTMLProcessor.py", line 1200, in sagenb.notebook.docHTMLProcessor.docutilsHTMLProcessor.start_pre
Failed example:
    p.temp_pieces
Expected:
    ['bunch ', 'of ', 'tmp ', 'strings', '<pre class="something-else">']
Got:
    ['bunch ', 'of ', 'tmp ', 'strings', u'<pre class="something-else">']
**********************************************************************
File "local/lib/python2.7/site-packages/sagenb-0.11.6-py2.7.egg/sagenb/notebook/docHTMLProcessor.py", line 1258, in sagenb.notebook.docHTMLProcessor.docutilsHTMLProcessor.end_pre
Failed example:
    p.temp_pieces
Expected:
    ['bunch ', 'of ', 'tmp ', 'strings', '<pre class="something-else">', 'some data', '</pre>']
Got:
    ['bunch ',
     'of ',
     'tmp ',
     'strings',
     u'<pre class="something-else">',
     'some data',
     u'</pre>']
**********************************************************************
File "local/lib/python2.7/site-packages/sagenb-0.11.6-py2.7.egg/sagenb/notebook/docHTMLProcessor.py", line 1335, in sagenb.notebook.docHTMLProcessor.docutilsHTMLProcessor.start_cite
Failed example:
    p.temp_pieces
Expected:
    ['bunch ', 'of ', 'tmp ', 'strings', '$'] 
Got:
    ['bunch ', 'of ', 'tmp ', 'strings', u'$']
**********************************************************************
File "local/lib/python2.7/site-packages/sagenb-0.11.6-py2.7.egg/sagenb/notebook/docHTMLProcessor.py", line 1355, in sagenb.notebook.docHTMLProcessor.docutilsHTMLProcessor.end_cite
Failed example:
    p.temp_pieces
Expected:
    ['bunch ', 'of ', 'tmp ', 'strings', '$', 'x^2', '$'] 
Got:
    ['bunch ', 'of ', 'tmp ', 'strings', u'$', 'x^2', u'$']
**********************************************************************

jdemeyer · 2015-12-14T11:32:52Z

comment:49

Apart from this, the notebook seems to work.

kcrisman · 2015-12-14T19:33:16Z

comment:50

Aargh!!! I knew something like this would happen. I apologize for not doing this - I thought SURELY this wouldn't change doctests and I wanted to make a package really quickly for when I wouldn't have a lot of access to Sage... well, shame on me.

kcrisman · 2015-12-14T19:35:26Z

comment:51

See sagemath/sagenb#357

kcrisman · 2015-12-15T02:53:57Z

comment:52

Now I remember why I didn't doctest it - because I didn't want to have to deal with checking #10295 at the same time because it would be complicated to test both... I will try to deal with this now, anyway.

sagetrac-git · 2015-12-15T13:48:53Z

Branch pushed to git repo; I updated commit sha1. New commits:

`bed31b2`	`Upgrade sagenb to version 0.11.6.1`

sagetrac-git · 2015-12-15T13:48:53Z

Changed commit from 0bb1df2 to bed31b2

kcrisman · 2015-12-15T13:52:46Z

comment:54

Okay, I have now hopefully taken care of everything...

tscrim · 2015-12-16T21:28:43Z

comment:56

AFAIK, the notebook works (including the live doc) and doctests pass. Ready to set a positive review?

jdemeyer · 2015-12-16T21:32:18Z

Changed dependencies from #19671 to #19671, #10295

jdemeyer · 2015-12-16T21:32:18Z

comment:57

I did not test the latest version, but the versions before seemed to work. So for me, this is good to go.

jdemeyer · 2015-12-16T21:41:01Z

Changed reviewer from Jeroen Demeyer to Jeroen Demeyer, Travis Scrimshaw

vbraun · 2015-12-22T19:50:42Z

Changed branch from u/kcrisman/ticket/19616 to bed31b2

kcrisman added this to the sage-6.10 milestone Nov 23, 2015

kcrisman added c: user interface labels Nov 23, 2015

This comment has been minimized.

Sign in to view

kcrisman added the s: needs review label Dec 3, 2015

jdemeyer added s: needs work and removed s: needs review labels Dec 4, 2015

kcrisman added s: needs review and removed s: needs work labels Dec 13, 2015

jdemeyer added s: needs work and removed s: needs review labels Dec 14, 2015

This comment has been minimized.

Sign in to view

kcrisman added s: needs review and removed s: needs work labels Dec 15, 2015

This comment has been minimized.

Sign in to view

jdemeyer added s: positive review and removed s: needs review labels Dec 16, 2015

vbraun removed the s: positive review label Dec 22, 2015

vbraun closed this as completed in 3524b13 Dec 22, 2015

kcrisman mentioned this issue Dec 10, 2015

Upgrade and optimize pexpect #10295

Closed

Update sagenb #19616

Update sagenb #19616

Comments

kcrisman commented Nov 23, 2015

kcrisman commented Dec 1, 2015

jdemeyer commented Dec 1, 2015

kcrisman commented Dec 1, 2015

jdemeyer commented Dec 1, 2015

kcrisman commented Dec 1, 2015

jdemeyer commented Dec 1, 2015

kcrisman commented Dec 1, 2015

kcrisman commented Dec 1, 2015

kcrisman commented Dec 2, 2015

kcrisman commented Dec 2, 2015

jdemeyer commented Dec 2, 2015

kcrisman commented Dec 2, 2015

This comment has been minimized.

kcrisman commented Dec 3, 2015

kcrisman commented Dec 3, 2015

This comment has been minimized.

kcrisman commented Dec 3, 2015

kcrisman commented Dec 3, 2015

jdemeyer commented Dec 4, 2015

kcrisman commented Dec 4, 2015

jdemeyer commented Dec 4, 2015

jdemeyer commented Dec 4, 2015

jdemeyer commented Dec 4, 2015

kcrisman commented Dec 13, 2015

jdemeyer commented Dec 13, 2015

kcrisman commented Dec 13, 2015

jdemeyer commented Dec 14, 2015

jdemeyer commented Dec 14, 2015

jdemeyer commented Dec 14, 2015

kcrisman commented Dec 14, 2015

kcrisman commented Dec 14, 2015

kcrisman commented Dec 15, 2015

sagetrac-git mannequin commented Dec 15, 2015

sagetrac-git mannequin commented Dec 15, 2015

kcrisman commented Dec 15, 2015

This comment has been minimized.

tscrim commented Dec 16, 2015

This comment has been minimized.

jdemeyer commented Dec 16, 2015

jdemeyer commented Dec 16, 2015

jdemeyer commented Dec 16, 2015

vbraun commented Dec 22, 2015