Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common generators for asymptotic expansions #19306

Closed
dkrenn opened this issue Sep 29, 2015 · 30 comments
Closed

common generators for asymptotic expansions #19306

dkrenn opened this issue Sep 29, 2015 · 30 comments

Comments

@dkrenn
Copy link
Contributor

dkrenn commented Sep 29, 2015

Implement common asymptotic expansion generators.

See also meta ticket #17601.

Depends on #19259
Depends on #19305

CC: @behackl @cheuberg

Component: asymptotic expansions

Author: Daniel Krenn

Branch/Commit: 4d80eb3

Reviewer: Clemens Heuberger

Issue created by migration from https://trac.sagemath.org/ticket/19306

@dkrenn
Copy link
Contributor Author

dkrenn commented Sep 29, 2015

Dependencies: #19305

@dkrenn
Copy link
Contributor Author

dkrenn commented Sep 29, 2015

Branch: u/dkrenn/asy/subs

@dkrenn
Copy link
Contributor Author

dkrenn commented Sep 29, 2015

Last 10 new commits:

30f7058write doctests for coercions, common_parent, pushout
a54b4afminor docstring rewriting of factory
fb2885csubring in index.rst
eab9513simplify a doctest
23352b2change ValueError to TypeError to make everything work with SR as it should
2d8b7c4typo in docstring
15ec40edocstring of SR.subring
7938d95module description of subring
852959arename only_constants --> no_variables
e83d82aMerge branch 'u/dkrenn/symbolic-subring' of trac.sagemath.org:sage into u/dakrenn/asy/subs

@dkrenn
Copy link
Contributor Author

dkrenn commented Sep 29, 2015

Changed branch from u/dkrenn/asy/subs to u/dkrenn/asy/generators

@dkrenn
Copy link
Contributor Author

dkrenn commented Sep 29, 2015

Commit: e83d82a

@dkrenn

This comment has been minimized.

@dkrenn

This comment has been minimized.

@dkrenn dkrenn changed the title generators for asymptotic expansions common generators for asymptotic expansions Sep 29, 2015
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 17, 2015

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

1ceba10Trac #19094/#19083 comment 66, 40: test conversion from multivariate polynomial ring
8006837Trac #19094/#19083 comment 66, 40: simplify test for empty data
4e5af11Trac #19094/#19083 comment 66, 36: delete ALGORITHM block
cb083d4Trac #19094/#19083 comment 66, 41: delete `_create_exact_summands_` since not needed
cf228bbTrac #19094/#19083 comment 66, 42: make creating of exact summand with growth but without coefficient impossible
a848139Trac #19094/#19083 comment 66, 42: create_summands: add doctests for interesting `data`
de137d1Trac #19083: fix one ReSt error
f9fbccbTrac #19083: expand description of parameter "convert"
46af62dMerge branch 'u/cheuberg/asy/prototype' of trac.sagemath.org:sage into t/19305/asy/subs
756ec67Merge branch 'u/dkrenn/asy/subs' of trac.sagemath.org:sage into t/19306/asy/generators

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 17, 2015

Changed commit from e83d82a to 756ec67

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 17, 2015

Changed commit from 756ec67 to 7124f13

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 17, 2015

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

204e47cdocstrings of `_substitute_` in term monoids
5cd22bfcomplete `_substitute_` of asymptotic ring
9d3a6e3let `__eq__` deal with noncomparable elements
5327238doctests: rewrite >>... to >...>
ef4ebb1rewrite main substitution method
2f434d7write doc and many doctests for substitute
975cea1Merge branch 't/19305/asy/subs' into t/19306/asy/generators
d08919cupdate copyright
fe5c176minor changes in docstrings
7124f13debug output (still work in progress)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 1, 2015

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

e4837e9correct parent of result of an_element
024ba1bMerge branch 'u/dkrenn/symbolic-subring' of trac.sagemath.org:sage into t/19306/asy/generators
f0c7440use symbolic constants subring (instead of SR)
0d6cce3remove automatic parenthesing in parent_to_repr_short
3f5e1b1fix bug in split_str_by_op
6e366a5binomial_kn_n: change to symbolic constants subring (WIP)
ae1877crename binomial* --> Binomial*
f0ab41adelete code of binomial* since it was
fd35046change base class to SageObject
532c41cwrite docstrings of Stirling generators

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 1, 2015

Changed commit from 7124f13 to 532c41c

@dkrenn
Copy link
Contributor Author

dkrenn commented Nov 1, 2015

Changed dependencies from #19305 to #19259, #19305

@dkrenn
Copy link
Contributor Author

dkrenn commented Nov 1, 2015

Author: Daniel Krenn

@cheuberg
Copy link
Contributor

Changed branch from u/dkrenn/asy/generators to u/cheuberg/asy/generators

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 15, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

cc256c8Trac #19306: remove old code
31e4dc4Trac #19306: other variables than n
a3fad56Trac #19306: fix error terms for low precision
a4c3f9dTrac #19306: Fix low precision for Stirling

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 15, 2016

Changed commit from 532c41c to a4c3f9d

@cheuberg
Copy link
Contributor

Reviewer: Clemens Heuberger

@cheuberg
Copy link
Contributor

comment:15

I reviewed this ticket (without looking at its dependency #19259). I added a commits, they need cross-review.

Two questions concerning misc.split_str_by_op:

  • Why += -1 instead of -= 1?
  • What is the purpose of the for...else construct: there is no break anyway.

@dkrenn
Copy link
Contributor Author

dkrenn commented Jan 16, 2016

Changed branch from u/cheuberg/asy/generators to u/dkrenn/asy/generators

@dkrenn
Copy link
Contributor Author

dkrenn commented Jan 16, 2016

comment:17

Replying to @cheuberg:

I reviewed this ticket (without looking at its dependency #19259). I added a commits, they need cross-review.

Done.

Two questions concerning misc.split_str_by_op:

  • Why += -1 instead of -= 1?

Changed.

  • What is the purpose of the for...else construct: there is no break anyway.

Changed. (else came from an old code)


New commits:

eac4977Trac #19306: minor changes (cross-review and incorporate reviewer comments)

@dkrenn
Copy link
Contributor Author

dkrenn commented Jan 16, 2016

Changed commit from a4c3f9d to eac4977

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 16, 2016

Changed commit from eac4977 to 946a828

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 16, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

946a828Trac #19306: change % to .format

@cheuberg
Copy link
Contributor

comment:19

LGTM; consider this as a positive review modulo the dependency #19259.

@cheuberg
Copy link
Contributor

Changed branch from u/dkrenn/asy/generators to u/cheuberg/asy/generators

@cheuberg
Copy link
Contributor

comment:21

#19259 is now positive, so this is positive, too.


New commits:

809d653Trac #19306: Merge tag '7.0' due to #19879
4d80eb3Trac #19306: sage.rings.arith -> sage.arith.all (after #19879)

@cheuberg
Copy link
Contributor

Changed commit from 946a828 to 4d80eb3

@vbraun
Copy link
Member

vbraun commented Jan 24, 2016

Changed branch from u/cheuberg/asy/generators to 4d80eb3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants