Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc 4.9.2 does not build on ARM #17348

Closed
vbraun opened this issue Nov 15, 2014 · 13 comments
Closed

gcc 4.9.2 does not build on ARM #17348

vbraun opened this issue Nov 15, 2014 · 13 comments

Comments

@vbraun
Copy link
Member

vbraun commented Nov 15, 2014

Upstream bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63740

Fixes it on our arm buildbot.

Component: build

Author: Volker Braun

Branch/Commit: fc9920e

Reviewer: Jean-Pierre Flori

Issue created by migration from https://trac.sagemath.org/ticket/17348

@vbraun vbraun added this to the sage-6.5 milestone Nov 15, 2014
@vbraun
Copy link
Member Author

vbraun commented Nov 15, 2014

@vbraun

This comment has been minimized.

@vbraun
Copy link
Member Author

vbraun commented Nov 15, 2014

Commit: a104fe6

@vbraun
Copy link
Member Author

vbraun commented Nov 15, 2014

New commits:

a104fe6Add upstream patch for ARM ICE

@vbraun
Copy link
Member Author

vbraun commented Nov 15, 2014

Author: Volker Braun

@jpflori
Copy link

jpflori commented Nov 17, 2014

comment:3

It's an upstream patch.
So I would happily positive review it.
I'll just let you argue why it's not documented in SPKG.txt first.

@jpflori
Copy link

jpflori commented Nov 17, 2014

@jpflori
Copy link

jpflori commented Nov 17, 2014

New commits:

c24897cMerge remote-tracking branch 'trac/u/vbraun/gcc_4_9_2_does_not_build_on_arm' into ticket/17348
fc9920eDocument GCC patch for ARM.

@jpflori
Copy link

jpflori commented Nov 17, 2014

Reviewer: Jean-Pierre Flori

@jpflori
Copy link

jpflori commented Nov 17, 2014

Changed commit from a104fe6 to fc9920e

@vbraun
Copy link
Member Author

vbraun commented Nov 17, 2014

comment:5

IMHO the patches should be documented in the patch, not in some other file. I did document it in the patch...

@jpflori
Copy link

jpflori commented Nov 17, 2014

comment:6

I kind of agree this would be better.

But as you can see, I just did it the old way as a "reviewer" commit as it was trivial.

@vbraun
Copy link
Member Author

vbraun commented Nov 17, 2014

Changed branch from u/jpflori/ticket/17348 to fc9920e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants